Add new quick-fixes#3756
Merged
datho7561 merged 1 commit intoeclipse-jdtls:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
jjohnstn
commented
Apr 13, 2026
jjohnstn
commented
- add new methods to ModifierCorrectionSubProcessor and enable quick-fixes that call them in QuickFixProcessor
- add new TypeArgumentMismatchSubProcessor class and enable quick-fix that uses it
- add new tests to ModifierCorrectionsQuickFixTest and add new TypeArgumentMismatchCorrectionTest
Contributor
Author
|
Hi @datho7561 These are some more quick-fixes enabled by some upstream JDT refactoring work I did last week. |
datho7561
approved these changes
Apr 15, 2026
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good and works well. Thanks, Jeff!
Contributor
|
Hmm. There's conflicts that need to be resolved before I merge this |
- add new methods to ModifierCorrectionSubProcessor and enable quick-fixes that call them in QuickFixProcessor - add new TypeArgumentMismatchSubProcessor class and enable quick-fix that uses it - add new tests to ModifierCorrectionsQuickFixTest and add new TypeArgumentMismatchCorrectionTest
jjohnstn
force-pushed
the
newquickfixes3
branch
from
c7922c6 to
8cef091
Compare
Contributor
Author
|
Hi @datho7561 The rebase did a horrible job of merging the branch into main. I fixed it up and did a force push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.