Remove deprecated sdv.v1 API code#211
Draft
SebastianSchildt wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 65.04% 67.95% +2.91%
==========================================
Files 37 29 -8
Lines 16977 13562 -3415
==========================================
- Hits 11042 9216 -1826
+ Misses 5935 4346 -1589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
e9f8c18 to
0d4aeac
Compare
Contributor
|
Are we sure we want to do this. I see a lot of people using the sdv.databroker.v1 from time to time? Shall we not continue supporting it? |
Contributor
|
I think hardening databroker for production use and thus removing deprecated API is indeed more important than some of the features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress. Do not merge
Will fix #202