Skip to content

Remove deprecated sdv.v1 API code#211

Draft
SebastianSchildt wants to merge 1 commit into
eclipse-kuksa:mainfrom
SebastianSchildt:feature/remove_sdv1_api
Draft

Remove deprecated sdv.v1 API code#211
SebastianSchildt wants to merge 1 commit into
eclipse-kuksa:mainfrom
SebastianSchildt:feature/remove_sdv1_api

Conversation

@SebastianSchildt
Copy link
Copy Markdown
Contributor

Work in progress. Do not merge

Will fix #202

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 97.69231% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.95%. Comparing base (5f47e92) to head (0d4aeac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
databroker-cli/src/main.rs 0.00% 2 Missing ⚠️
databroker/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   65.04%   67.95%   +2.91%     
==========================================
  Files          37       29       -8     
  Lines       16977    13562    -3415     
==========================================
- Hits        11042     9216    -1826     
+ Misses       5935     4346    -1589     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sebastian Schildt <sebastian.schildt@hs-heilbronn.de>
@SebastianSchildt SebastianSchildt force-pushed the feature/remove_sdv1_api branch from e9f8c18 to 0d4aeac Compare April 29, 2026 09:01
@lukasmittag
Copy link
Copy Markdown
Contributor

Are we sure we want to do this. I see a lot of people using the sdv.databroker.v1 from time to time? Shall we not continue supporting it?

@mikehaller @BjoernAtBosch

@mikehaller
Copy link
Copy Markdown
Contributor

I think hardening databroker for production use and thus removing deprecated API is indeed more important than some of the features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove sdv 1 API code

3 participants