Fix review findings

Author: BjoernAtBosch

kuksa-client/kuksa_client/grpc/__init__.py

@@ -991,6 +991,9 @@ def wrapper(self, *args, **kwargs):
         return wrapper
 
     def connect(self, target_host=None):
+        # Reset the id mapping on each new connection to the data broker because the broker
+        # could have been restarted and assigned new ids to paths in between.
+        # Furthermore, the specified target host could have changed.
         self.path_to_id_mapping.clear()
         self.id_to_path_mapping.clear()
 
@@ -1223,7 +1226,7 @@ def subscribe_target_values(
         """
         try:
             logger.debug("Try to subscribe actuation requests via v2")
-            for updates in self.v2_subscribe_batch_actuation(paths, **rpc_kwargs):
+            for updates in self.v2_subscribe_actuation_requests(paths, **rpc_kwargs):
                 yield {
                     update.entry.path: update.entry.actuator_target for update in updates
                 }
@@ -1392,7 +1395,7 @@ def subscribe(
                     "code": grpc.StatusCode.INVALID_ARGUMENT.value[0],
                     "reason": grpc.StatusCode.INVALID_ARGUMENT.value[1],
                     "message": ("Method subscribe supports v1, only. "
-                                "Use v2_subscribe or v2_subscribe_batch_actuation instead."),
+                                "Use v2_subscribe or v2_subscribe_actuation_requests instead."),
                 },
                 errors=[],
             )
@@ -1437,7 +1440,7 @@ def v2_subscribe(
             raise VSSClientError.from_grpc_error(exc) from exc
 
     @check_connected
-    def v2_subscribe_batch_actuation(
+    def v2_subscribe_actuation_requests(
         self, paths: Iterable[str], **rpc_kwargs
     ) -> Iterator[List[EntryUpdate]]:
         """

kuksa-client/kuksa_client/grpc/aio.py

@@ -341,7 +341,7 @@ async def subscribe_target_values(
         """
         try:
             logger.debug("Try to subscribe actuation requests via v2")
-            async for updates in self.v2_subscribe_batch_actuation(paths=paths, **rpc_kwargs):
+            async for updates in self.v2_subscribe_actuation_requests(paths=paths, **rpc_kwargs):
                 yield {
                     update.entry.path: update.entry.actuator_target for update in updates
                 }
@@ -515,7 +515,7 @@ async def subscribe(
                     "code": grpc.StatusCode.INVALID_ARGUMENT.value[0],
                     "reason": grpc.StatusCode.INVALID_ARGUMENT.value[1],
                     "message": ("Method subscribe supports v1, only. "
-                                "Use v2_subscribe or v2_subscribe_batch_actuation instead."),
+                                "Use v2_subscribe or v2_subscribe_actuation_requests instead."),
                 },
                 errors=[],
             )
@@ -560,7 +560,7 @@ async def v2_subscribe(
             raise VSSClientError.from_grpc_error(exc) from exc
 
     @check_connected_async_iter
-    async def v2_subscribe_batch_actuation(
+    async def v2_subscribe_actuation_requests(
         self, paths: Iterable[str], **rpc_kwargs
     ) -> AsyncIterator[List[EntryUpdate]]:
         """

kuksa-client/tests/test_grpc.py

@@ -683,7 +683,7 @@ async def subscribe_response_stream(**kwargs):
                 EntryUpdate(DataEntry('Vehicle.Chassis.SteeringWheel.Tilt',
                             actuator_target=Datapoint(42)), (Field.ACTUATOR_TARGET,)),
             ]
-        mocker.patch.object(client, 'v2_subscribe_batch_actuation',
+        mocker.patch.object(client, 'v2_subscribe_actuation_requests',
                             side_effect=subscribe_response_stream)
 
         received_updates = {}
@@ -692,7 +692,7 @@ async def subscribe_response_stream(**kwargs):
         ]):
             received_updates.update(updates)
 
-        assert list(client.v2_subscribe_batch_actuation.call_args_list[0][1]['paths']) == [
+        assert list(client.v2_subscribe_actuation_requests.call_args_list[0][1]['paths']) == [
             'Vehicle.ADAS.ABS.IsActive',
             'Vehicle.Chassis.SteeringWheel.Tilt',
         ]
@@ -1846,7 +1846,7 @@ async def test_subscribe_some_entries_v2_target(
             actual_responses = []
 
             with pytest.raises(VSSClientError):
-                async for updates in client.v2_subscribe_batch_actuation(
+                async for updates in client.v2_subscribe_actuation_requests(
                     paths=(
                         path
                         for path in (  # generator is intentional (Iterable)