Use ProcessHandle instead of shell script to check for parent process#1753
Merged
Conversation
Contributor
|
Code LGTM, but I haven't tested it. @datho7561 have you? |
Contributor
Author
|
I made sure it still runs as normal, but I haven't tried killing the parent process manually yet, I should do that... |
Contributor
|
What about binary? Is it working? |
datho7561
force-pushed
the
use-process-handle
branch
from
September 9, 2025 13:57
299cc95 to
2151985
Compare
Contributor
Author
|
I made sure that lemminx starts up properly, then closed all VS Code abnormally ( |
fbricon
reviewed
Sep 9, 2025
See eclipse-lemminx#1025 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
use-process-handle
branch
from
September 9, 2025 14:58
2151985 to
7dc505e
Compare
datho7561
added a commit
to datho7561/quarkus-ls
that referenced
this pull request
Sep 9, 2025
See eclipse-lemminx/lemminx#1753 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to datho7561/quarkus-ls
that referenced
this pull request
Sep 9, 2025
See eclipse-lemminx/lemminx#1753 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
added a commit
to redhat-developer/quarkus-ls
that referenced
this pull request
Sep 9, 2025
See eclipse-lemminx/lemminx#1753 Signed-off-by: David Thompson <davthomp@redhat.com>
Contributor
|
Thanks @datho7561! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1025