Do not create document links with zero length range#1761
Merged
angelozerr merged 1 commit intoNov 4, 2025
Conversation
angelozerr
reviewed
Nov 3, 2025
datho7561
force-pushed
the
1110-document-link-range
branch
from
November 4, 2025 14:54
5832cb6 to
d229805
Compare
angelozerr
reviewed
Nov 4, 2025
datho7561
force-pushed
the
1110-document-link-range
branch
from
November 4, 2025 15:59
d229805 to
29a2795
Compare
Ultimately, a zero length document link doesn't make sense. VS Code throws an error when attempting to consume a zero length document link. To test this change, try the reproducer example that I added in the linked issue. Fixes redhat-developer/vscode-xml#1110 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1110-document-link-range
branch
from
November 4, 2025 16:00
29a2795 to
eecac25
Compare
angelozerr
approved these changes
Nov 4, 2025
Contributor
|
Thanks @datho7561 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimately, a zero length document link doesn't make sense. VS Code throws an error when attempting to consume a zero length document link.
To test this change, try the reproducer example that I added in the linked issue.
Fixes redhat-developer/vscode-xml#1110