Skip to content

Add preference option for non-buffered file handling in Xtext editors.#1517

Open
raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
raghucssit:pref-non-fb-res-lisn
Open

Add preference option for non-buffered file handling in Xtext editors.#1517
raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
raghucssit:pref-non-fb-res-lisn

Conversation

@raghucssit
Copy link
Copy Markdown
Contributor

see #1500

Copilot AI review requested due to automatic review settings April 9, 2026 00:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a UI preference to control “non-buffered file handling” so LSP4E can better support editors (e.g., Xtext) whose IDocument is not backed by Eclipse file buffers, aligning with #1500.

Changes:

  • Added a new translatable UI label for the preference.
  • Exposed a new checkbox on the Language Server preference page backed by org.eclipse.lsp4e.resourceFallback.enabled.
  • Persisted the checkbox value to the plugin preference store on OK.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/messages.properties Adds the UI string for the new preference checkbox.
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/Messages.java Exposes the new message key to the NLS bundle.
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java Adds the checkbox and saves/loads the preference value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rubenporras
Copy link
Copy Markdown
Contributor

Hi @raghucssit ,

I think the end user should not be interested in such flag. Could we instead enable it in the Activator of CoPilot plugin?

@raghucssit raghucssit force-pushed the pref-non-fb-res-lisn branch from 276013c to c7e9636 Compare April 12, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants