Add preference option for non-buffered file handling in Xtext editors.#1517
Open
raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Open
Add preference option for non-buffered file handling in Xtext editors.#1517raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
raghucssit wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a UI preference to control “non-buffered file handling” so LSP4E can better support editors (e.g., Xtext) whose IDocument is not backed by Eclipse file buffers, aligning with #1500.
Changes:
- Added a new translatable UI label for the preference.
- Exposed a new checkbox on the Language Server preference page backed by
org.eclipse.lsp4e.resourceFallback.enabled. - Persisted the checkbox value to the plugin preference store on OK.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/messages.properties |
Adds the UI string for the new preference checkbox. |
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/Messages.java |
Exposes the new message key to the NLS bundle. |
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java |
Adds the checkbox and saves/loads the preference value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
Show resolved
Hide resolved
org.eclipse.lsp4e/src/org/eclipse/lsp4e/ui/LanguageServerPreferencePage.java
Show resolved
Hide resolved
Contributor
|
Hi @raghucssit , I think the end user should not be interested in such flag. Could we instead enable it in the Activator of CoPilot plugin? |
276013c to
c7e9636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1500