Fix path parsing on Windows in SymbolIconProviderRegistry & add tests#1532
Conversation
travkin79
changed the title
travkin79
changed the title
- Add test case for reproducing a windows path parsing issue - Move helper method to utility class - Fix path parsing: Path.of(uri.getPath()) => Path.of(uri) - Bump test plug-in version
travkin79
force-pushed
the
patch-add-icon-provider-test
branch
from
973e19c to
b2f851e
Compare
|
Thank you @FlorianKroiss for your review. Hello @rubenporras, do you think, we could merge now? I squashed and rebased my PR commits. Oh, I see, the license check fails, but I don't see the reason. Any suggestions? Besides, I'm wondering about some of our tests sporadically failing for strange reasons. Are there any ideas how we could avoid that? |
I have just a minor comment, could you take a look and follow my suggestion or comment if you disagree? Then we can merge. Sorry for the late review, I have been on holidays for a week and forgot to set my status on GitHub, so it was not visible.
@travkin79 , I have triggered the job again and it succeded. I must have been a temporal glitch.
I have been wondering as well but I have currently not much time to work on LSP4E so I cannot help. |
travkin79
force-pushed
the
patch-add-icon-provider-test
branch
from
1f1c368 to
6a27c5d
Compare
|
Hi @rubenporras,
I agree with your suggestion and adapted the code accordingly.
No problem. |
|
Thank you @rubenporras. |
|
fyi: I have also created a new release |
…608) * Customize C/C++ destructor symbol overlay icons in outline view * Increase min. LSP4E version because of required LSP4E extension point We depend on the new LSP4E extension point "org.eclipse.lsp4e.symbolIconsProvider" that was introduced in org.eclipse.lsp4e vers. 0.19.10 (LSP4E 0.30.3). * Add test case for custom symbol icon provider * Do not register custom icon provider for C Only C++ needs to be considered here * Cache destructor overlay icon * Remove unused method * Add given, when, then comments to test * Increase min. LSP4E version in order to include LSP4E bug fix Include PR eclipse-lsp4e/lsp4e#1532
3 participants
On Windows a path parsing issue can occur while retrieving overlay icons for the outline view, type hierarchy, or call hierarchy. This PR provides a fix for an issue reported in CDT LSP and adds a test for reproducing that issue.