Finalize support for LSP 3.18.0#977
Conversation
* Removed `@ProtocolDraft` annotations for LSP 3.18.0 elements * Added `RegularExpressionEngineKind` * Added `SignatureInformationCapabilities.noActiveParameterSupport` * Added convenience constructors for `Diagnostic`, `DocumentFilter`, and `NotebookDocumentFilter` * Minor updates to LSP Javadocs Closes eclipse-lsp4j#974.
|
@nixel2007 Thanks for the review! 👍 |
|
Hi @nixel2007 @pisv when to merge this PR, and any plan to ship the release? |
|
we also should check the 3.18.1 patch |
@wenytang-ms Currently, LSP4J has no ETA for the next release as far as I know. However, as you can see the difference between this PR and LSP4J 1.0.0 is quite minimal apart from the I plan to merge this PR soon. If anyone would like to review it, but currently have no time, please let me know ASAP. |
I'd address it in a separate PR for better traceability of the changes. However, I could find no references to the LSP 3.18.1. Is it even planned? |
|
there is a new version of the npm package. this is why it showed on my radar |
I see now, thanks. Looking at their CHANGELOG, it only concerns the implementation of the npm package, not the protocol itself. |
4 participants
@ProtocolDraftannotations for LSP 3.18.0 elementsRegularExpressionEngineKindSignatureInformationCapabilities.noActiveParameterSupportDiagnostic,DocumentFilter, andNotebookDocumentFilterCloses #974.