Only consider existing artifacts for the classpath#1682
Only consider existing artifacts for the classpath#1682laeubi wants to merge 1 commit intoeclipse-m2e:mainfrom
Conversation
39e717f to
2bf3489
Compare
HannesWell
left a comment
There was a problem hiding this comment.
Looks like there are test-failures now. Don't know if they are only due to changed circumstances or are really meaning full.
It would be good to add a test for the case you described.
Sadly the commented out line goes back until the Initial commit at Eclipse. Would have been nice to know why this was disabled. :/
|
@HannesWell yes thats why I have disabled it to see what / if test fails, sadly some tests are written wit some numbers of problems in the expectation without looking at the content. At least it show it has an effect .. but probably not something for the current release. |
Yes, that's what I meant with non meaningful tests :)
Yes, lets keep this for the next cycle. |
Currently only if the artifact file is null it is not considered but if the file does not exits JDT complains. It even seems there was once in a time such a check but it is disabled, this is an attempt to check if we can reenable it again.
2bf3489 to
f43fdbe
Compare
Currently only if the artifact file is null it is not considered but if the file does not exits JDT complains. It even seems there was once in a time such a check but it is disabled, this is an attempt to check if we can reenable it again.