Skip to content

Commit 944dfad

Browse files
gnl42ruspl-afed
authored andcommitted
Little progress update shown for Github query #1106
Task-Url: #1106
1 parent be50b16 commit 944dfad

1 file changed

Lines changed: 18 additions & 13 deletions

File tree

  • mylyn.github/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue

mylyn.github/org.eclipse.mylyn.github.core/src/org/eclipse/mylyn/internal/github/core/issue/IssueConnector.java

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.eclipse.core.runtime.IProgressMonitor;
2929
import org.eclipse.core.runtime.IStatus;
3030
import org.eclipse.core.runtime.Status;
31+
import org.eclipse.core.runtime.SubMonitor;
3132
import org.eclipse.egit.github.core.Comment;
3233
import org.eclipse.egit.github.core.IRepositoryIdProvider;
3334
import org.eclipse.egit.github.core.Issue;
@@ -287,7 +288,7 @@ public IStatus performQuery(TaskRepository repository, IRepositoryQuery query, T
287288
List<String> statuses = QueryUtils.getAttributes(
288289
IssueService.FILTER_STATE, query);
289290

290-
monitor.beginTask(Messages.IssueConector_TaskQuerying, statuses.size());
291+
SubMonitor subMonitor = SubMonitor.convert(monitor, Messages.IssueConector_TaskQuerying, statuses.size() * 100);
291292
try {
292293
RepositoryId repo = GitHub.getRepository(repository.getRepositoryUrl());
293294

@@ -324,28 +325,32 @@ public IStatus performQuery(TaskRepository repository, IRepositoryQuery query, T
324325
String name = repo.getName();
325326
for (String status : statuses) {
326327
filterData.put(IssueService.FILTER_STATE, status);
328+
SubMonitor statusMonitor = subMonitor.split(100);
329+
statusMonitor.setTaskName(status + Messages.IssueConnector_LabelIssues);
327330
List<Issue> issues = service.getIssues(repo.getOwner(), repo.getName(), filterData);
331+
statusMonitor.checkCanceled();
328332

329333
// collect task data
334+
statusMonitor.setWorkRemaining(issues.size());
330335
for (Issue issue : issues) {
331-
if (isPullRequest(issue)) {
332-
continue;
336+
if (!isPullRequest(issue)) {
337+
List<Comment> comments = null;
338+
if (issue.getComments() > 0) {
339+
comments = service.getComments(owner, name, Integer.toString(issue.getNumber()));
340+
}
341+
TaskData taskData = taskDataHandler.createTaskData(repository, statusMonitor, owner, name,
342+
issue, comments);
343+
collector.accept(taskData);
333344
}
334-
List<Comment> comments = null;
335-
if (issue.getComments() > 0) {
336-
comments = service.getComments(owner, name, Integer.toString(issue.getNumber()));
337-
}
338-
TaskData taskData = taskDataHandler.createTaskData(
339-
repository, monitor, owner, name, issue, comments);
340-
collector.accept(taskData);
345+
statusMonitor.split(1);
341346
}
342-
monitor.worked(1);
347+
statusMonitor.done();
343348
}
344349
} catch (IOException e) {
345350
result = GitHub.createWrappedStatus(e);
351+
} finally {
352+
subMonitor.done();
346353
}
347-
348-
monitor.done();
349354
return result;
350355
}
351356

0 commit comments

Comments
 (0)