Skip to content

Remove Wizard SVGs#715

Merged
ruspl-afed merged 1 commit into
eclipse-mylyn:mainfrom
Michael5601:remove-wizard-SVGs
May 21, 2025
Merged

Remove Wizard SVGs#715
ruspl-afed merged 1 commit into
eclipse-mylyn:mainfrom
Michael5601:remove-wizard-SVGs

Conversation

@Michael5601
Copy link
Copy Markdown

@Michael5601 Michael5601 commented May 14, 2025

This PR reverts the addition of SVGs for wizard icons of merged PR.

As stated by @HeikoKlare in this comment the mechanism for creating SVGs for the wizard icons is not sufficient. This was my bad but some SVGs were already merged to Mylyn yesterday and thus need to be removed by this PR.

Please note that 5 SVGs where added yesterday which will be deleted by this PR. The reason why only 4 paths are changed is that for the icon secur_role_wiz the path was never changed to .svg and thus remains as .gif.

@Michael5601
Copy link
Copy Markdown
Author

@ruspl-afed @merks can you please check this small change?

@ruspl-afed
Copy link
Copy Markdown
Contributor

Ooops. TBH I had no time to check it in action. Could you please post here a screenshot how it looks with the content of this PR applied @Michael5601 ?

@Michael5601
Copy link
Copy Markdown
Author

Ooops. TBH I had no time to check it in action. Could you please post here a screenshot how it looks with the content of this PR applied @Michael5601 ?

Well it looks like the standard behaviour before the first change. In this PR I only reverted changes so the Wizard icons look like before (loaded with GIFs instead of SVGs).

I have some problems starting an Eclipse Application with Mylyn right now so I sadly can't provide any screenshots.

This commit deletes previously added wizard SVGs as the quality is not sufficient.
@ruspl-afed
Copy link
Copy Markdown
Contributor

so I sadly can't provide any screenshots.

I agree, this is sad.
I'm going to give it a try, because I appreciate your effort to make Mylyn better @Michael5601
And please let me kindly ask you to have a look on it in upcoming M3,

@ruspl-afed ruspl-afed merged commit 81a6207 into eclipse-mylyn:main May 21, 2025
3 checks passed
@Michael5601
Copy link
Copy Markdown
Author

so I sadly can't provide any screenshots.

I agree, this is sad. I'm going to give it a try, because I appreciate your effort to make Mylyn better @Michael5601 And please let me kindly ask you to have a look on it in upcoming M3,

I will try to fix my setup for mylyn as soon as I find some time, then I can provide the screenshots :)

@ruspl-afed
Copy link
Copy Markdown
Contributor

I will try to fix my setup for mylyn as soon as I find some time, then I can provide the screenshots :)

Definitely, it is good to have working Mylyn setup. However I hope you can also try to grab any M3 package with Mylyn tomorrow

@Michael5601 Michael5601 deleted the remove-wizard-SVGs branch May 27, 2025 08:31
@Michael5601
Copy link
Copy Markdown
Author

Michael5601 commented May 27, 2025

I will try to fix my setup for mylyn as soon as I find some time, then I can provide the screenshots :)

Definitely, it is good to have working Mylyn setup. However I hope you can also try to grab any M3 package with Mylyn tomorrow

Here are some screenshots of the Mylyn Tasks UI in 125% zoom. The new SVGs are working great. I could not find any problems but please note that many icons in Mylyn are not available as SVGs (and many are still GIFs) yet. I will try to document the missing icons here.

image

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants