Skip to content

Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core#783

Open
eclipse-mylyn-bot wants to merge 1 commit into
mainfrom
clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core
Open

Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core#783
eclipse-mylyn-bot wants to merge 1 commit into
mainfrom
clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core

Conversation

@eclipse-mylyn-bot
Copy link
Copy Markdown
Contributor

@eclipse-mylyn-bot eclipse-mylyn-bot commented Aug 9, 2025

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 9, 2025

Test Results

 1 626 files  ±0   1 626 suites  ±0   1h 22m 16s ⏱️ - 1m 13s
 5 354 tests ±0   5 273 ✅ ±0   81 💤 ±0  0 ❌ ±0 
13 476 runs  ±0  13 241 ✅ ±0  235 💤 ±0  0 ❌ ±0 

Results for commit 93a8d94. ± Comparison against base commit ee5fcfc.

♻️ This comment has been updated with latest results.


private static class NameValue {

@SuppressWarnings("unused")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this is needed for persistence or something similar

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we really need these fields @gnl42 ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is used to build a json string for the Jenkins Form; but I can not find a unit test where parm is filled. So not sure if we can safely delete parts and the private Classes.

@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 3 times, most recently from 5e4ee75 to c3159f8 Compare August 13, 2025 02:44
@ruspl-afed ruspl-afed force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from c3159f8 to 5f914d7 Compare August 13, 2025 06:48
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 8 times, most recently from e0b74e5 to 303ce63 Compare August 21, 2025 02:41
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 5 times, most recently from c0aa40b to 8fcfc12 Compare August 28, 2025 02:39
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 8fcfc12 to fa58bc6 Compare September 4, 2025 02:36
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from e4db08a to 617c532 Compare September 15, 2025 02:42
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 5 times, most recently from 3135845 to 491f500 Compare September 27, 2025 02:35
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 491f500 to 4f8e33c Compare September 29, 2025 02:40
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 4f8e33c to c4275d9 Compare October 8, 2025 11:10
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 66bad69 to 925b83d Compare December 10, 2025 02:46
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 30cfe97 to 0e0d57e Compare December 14, 2025 02:51
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 54faaf8 to 3f56613 Compare December 30, 2025 02:49
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 3f56613 to c5e9bf6 Compare January 7, 2026 02:52
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 6a8da41 to 1189032 Compare January 28, 2026 02:55
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 59631fb to 1858d4a Compare February 6, 2026 03:11
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from ce71a90 to 7979b87 Compare February 22, 2026 03:13
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 5 times, most recently from 84b7f02 to cba896c Compare March 4, 2026 03:08
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 3 times, most recently from da53d17 to c16fd47 Compare March 13, 2026 03:09
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from c16fd47 to 991c839 Compare March 21, 2026 03:05
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 2 times, most recently from 590fb65 to 75397d8 Compare April 2, 2026 03:15
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch from 75397d8 to a654121 Compare April 9, 2026 03:16
@eclipse-mylyn-bot eclipse-mylyn-bot force-pushed the clean-code/mylyn.builds/org.eclipse.mylyn.jenkins.core branch 4 times, most recently from 7070b95 to 68f8cf4 Compare April 22, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants