Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core#783
Open
eclipse-mylyn-bot wants to merge 1 commit into
Open
Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core#783eclipse-mylyn-bot wants to merge 1 commit into
eclipse-mylyn-bot wants to merge 1 commit into
Conversation
ruspl-afed
reviewed
Aug 9, 2025
|
|
||
| private static class NameValue { | ||
|
|
||
| @SuppressWarnings("unused") |
Contributor
There was a problem hiding this comment.
perhaps this is needed for persistence or something similar
Contributor
There was a problem hiding this comment.
Do you know if we really need these fields @gnl42 ?
Contributor
There was a problem hiding this comment.
Yes it is used to build a json string for the Jenkins Form; but I can not find a unit test where parm is filled. So not sure if we can safely delete parts and the private Classes.
5e4ee75 to
c3159f8
Compare
c3159f8 to
5f914d7
Compare
e0b74e5 to
303ce63
Compare
c0aa40b to
8fcfc12
Compare
8fcfc12 to
fa58bc6
Compare
e4db08a to
617c532
Compare
3135845 to
491f500
Compare
491f500 to
4f8e33c
Compare
4f8e33c to
c4275d9
Compare
66bad69 to
925b83d
Compare
30cfe97 to
0e0d57e
Compare
54faaf8 to
3f56613
Compare
3f56613 to
c5e9bf6
Compare
6a8da41 to
1189032
Compare
59631fb to
1858d4a
Compare
ce71a90 to
7979b87
Compare
84b7f02 to
cba896c
Compare
da53d17 to
c16fd47
Compare
c16fd47 to
991c839
Compare
590fb65 to
75397d8
Compare
75397d8 to
a654121
Compare
7070b95 to
68f8cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following cleanups were applied: