normalize eol for monaco client as well.#195
Open
jonah-iden wants to merge 1 commit intomainfrom
Open
Conversation
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
There was a problem hiding this comment.
Pull request overview
Normalizes end-of-line sequences when resyncing Yjs text into a Monaco ITextModel, aligning Monaco client behavior with the existing VS Code extension approach and preventing spurious full-document updates caused solely by EOL differences.
Changes:
- Apply EOL normalization when computing resync content from
yjsText.toString()for Monaco models. - Introduce a small
adjustEolhelper to map text to the model’sEndOfLineSequence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as we are doing in the vscode extension