Added service process release process#197
Merged
Merged
Conversation
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
spoenemann
approved these changes
May 12, 2026
spoenemann
left a comment
spoenemann
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good. Question: would it be useful to also publish a bundled version of the service process without a runtime? That would be platform-independent and could be used in cases where a Node.js runtime is already available.
| fi | ||
|
|
||
| cp "$SOURCE" "$TARGET" | ||
| echo "asset_name=$TARGET" >> "$GITHUB_OUTPUT" |
Contributor
There was a problem hiding this comment.
Were you able to test these more complex shell scripts locally?
Contributor
Author
There was a problem hiding this comment.
i wasn't able to test it through act or something like that but with some modifications to the script yes. Seems to work fine
Contributor
Author
|
@spoenemann Thats actually a good point. Yeah that might make sense. What would the goto way be for that? An npm package or rather a zip? |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Contributor
|
An npm package with a bin field would probably be best. |
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adde a release process for the service process to create prebuild binaries
Improvements for later
maybe evaluate bun as runtime for smaller binaries. Because right the windows binary for example is ~90mb large
maybe evaluate UPX for reducing the binary size
maybe rather zip/targz the binaries for smaller binary sizes