Stale OOMPH URLs

[ewillink]

I have just had a JustJ promotion job fail because I had failed to update a usage of https://git.eclipse.org/r/modisco/org.eclipse.modisco. My bad, but why does it only fail today? It seems that some redirection has been broken / discontinued by the EF.

NB. Even when the old URL 'works', it is dangerous since it references the increasingly stale repo and so misses any updates such as consistent support for the migrated repo spelling.

Searching my workspace for git.eclipse.org/r and git.eclipse.org/c I find, that my OOMPH setups have

xsi:schemaLocation="http://www.eclipse.org/oomph/setup/git/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Git.ecore http://www.eclipse.org/oomph/setup/jdt/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/JDT.ecore http://www.eclipse.org/oomph/predicates/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Predicates.ecore http://www.eclipse.org/oomph/setup/projects/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Projects.ecore http://www.eclipse.org/oomph/setup/targlets/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/SetupTarglets.ecore http://www.eclipse.org/oomph/setup/workingsets/1.0 http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/SetupWorkingSets.ecore"

Today http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/Git.ecore opens fine in Firefox, but for how much longer?

Will OOMPH have an internal hardwired redirection, or should all OOMPH setup files be changed to avoid future bit rot?

[merks]

Saving a setup with a more recent implementation of Oomph will serialize like this:

• oomph/setups/org.eclipse.projects.setup

  Line 9 in 7dd34da

  xsi:schemaLocation="http://www.eclipse.org/oomph/setup/pde/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/PDE.ecore http://www.eclipse.org/oomph/setup/targlets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/SetupTarglets.ecore"

• oomph/setups/Oomph.setup

  Line 15 in 7dd34da

  xsi:schemaLocation="http://www.eclipse.org/oomph/setup/git/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Git.ecore http://www.eclipse.org/oomph/setup/jdt/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/JDT.ecore http://www.eclipse.org/oomph/predicates/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Predicates.ecore http://www.eclipse.org/oomph/setup/targlets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/SetupTarglets.ecore http://www.eclipse.org/oomph/setup/workingsets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/SetupWorkingSets.ecore http://www.eclipse.org/oomph/setup/workbench/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/Workbench.ecore http://www.eclipse.org/oomph/workingsets/1.0 https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/models/WorkingSets.ecore"

For backwards compatibility the setup archiver:

• https://ci.eclipse.org/oomph/job/setup-archiver/

• oomph/plugins/org.eclipse.oomph.setup.core/src/org/eclipse/oomph/setup/internal/core/SetupArchiver.java

  Lines 84 to 86 in 7dd34da

  	private static final URI HTTPS_LEGACY_MODELS = URI.createURI("https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/"); //$NON-NLS-1$
  	private static final URI HTTP_LEGACY_MODELS = URI.createURI("http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/models/"); //$NON-NLS-1$

stores results in the old/ancient location in the setups.zip like this:

This approach effectively sets up redirects within the IDE/installer when processing *.setup resource such that the old locations do work, but without actually accessing the git.eclipse.org host. In fact, it's been a very long time since we allowed resources to be loaded from that host except in the setup archive application.

oomph/plugins/org.eclipse.oomph.setup.core/src/org/eclipse/oomph/setup/internal/core/util/ECFURIHandlerImpl.java

Lines 1426 to 1433 in 7dd34da

	// To prevent Eclipse's Git server from being overload, because it can't scale to thousands of users, we block all direct access.
	String host = getHost(uri);
	boolean isBlockedEclipseGitURI = !SetupUtil.SETUP_ARCHIVER_APPLICATION && "git.eclipse.org".equals(host); //$NON-NLS-1$
	if (isBlockedEclipseGitURI && uriConverter.exists(cacheURI, options))
	{
	// If the file is in the cache, it's okay to use that cached version, so try that first.
	cacheHandling = CacheHandling.CACHE_ONLY;
	}

With the recent fix in UML2

eclipse-uml2/uml2#121

the setup archiver itself no longer requires any access to http://git.eclipse.org/c/ which has gotten decided flaky cause way too many build failures.

So all is set for git.eclipse.org to go down permanently, yes there are hardwired redirections in place, but best to update the setup files.