Fix AllocationAge overflow issue#23997
Open
LinHu2016 wants to merge 3 commits into
Open
Conversation
LinHu2016
force-pushed
the
allocationAgeUpdate
branch
from
3da0645 to
c16bf74
Compare
Contributor
Author
|
@amicic @dmitripivkine please review the changes, Thanks |
LinHu2016
force-pushed
the
allocationAgeUpdate
branch
5 times, most recently
from
0756fd9 to
375f008
Compare
LinHu2016
force-pushed
the
allocationAgeUpdate
branch
2 times, most recently
from
821d23e to
8e7dd08
Compare
During setAllocationAgeForMergedRegion(), newAllocationAge is calculated from getAllocationAgeSizeProduct()/sedBytes(region->getSize() - region->getMemoryPool()->getFreeMemoryAndDarkMatterBytes()). Dark matter overestimation causes usedBytes to be underestimated. This leads to AllocationAge > tarokMaximumAgeInBytes, causing overflow. The overflow results in inaccurate projections and potential Boundaries Overflow. - Introduces _usedAllocationBytes field to track actual copied bytes. - Updates setAllocationAgeSizeProduct() to accept usedAllocationBytes parameter. - Uses getUsedAllocationBytes() instead of derived calculations. Signed-off-by: lhu <linhu@ca.ibm.com>
Signed-off-by: lhu <linhu@ca.ibm.com>
LinHu2016
force-pushed
the
allocationAgeUpdate
branch
from
8e7dd08 to
7c65f0d
Compare
LinHu2016
force-pushed
the
allocationAgeUpdate
branch
from
7c65f0d to
5c4f201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During setAllocationAgeForMergedRegion(), newAllocationAge is calculated
from getAllocationAgeSizeProduct()/sedBytes(region->getSize() -
region->getMemoryPool()->getFreeMemoryAndDarkMatterBytes()).
Dark matter overestimation causes usedBytes to be underestimated.
This leads to AllocationAge > tarokMaximumAgeInBytes, causing overflow.
The overflow results in inaccurate projections and potential Boundaries
Overflow.
parameter.
Signed-off-by: lhu linhu@ca.ibm.com