Align Unsafe.arrayLayout(Object[] array) for Valhalla compatibility#24286
Align Unsafe.arrayLayout(Object[] array) for Valhalla compatibility#24286konark2010 wants to merge 1 commit into
Conversation
|
@theresa-m and @hangshao0 please review |
|
@konark2010 do you have a personal build to show that this is working with the Valhalla unsafe tests? |
hangshao0
added
comp:vm
project:valhalla
No I do not have any build for it but will do it now |
You need to add your repos and branches as well under OPENJ9_REPO/OPENJ9_BRANCH and OPENJDK_REPO/OPENJDK_BRANCH. |
konark2010
force-pushed
the
valhalla-change-match
branch
2 times, most recently
from
e7f4b12 to
dc3c445
Compare
@konark2010 Do you have an updated and passed personal build ? |
I have an another build but it got fail in some tests, so I am working on their fix |
konark2010
force-pushed
the
valhalla-change-match
branch
2 times, most recently
from
d1a8e2e to
e5e79ff
Compare
|
Personal build that is passing: https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/34523/ |
|
Please update the description to accurately describe the change. There is only one arrayLayout method so there is no overloading here. |
konark2010
force-pushed
the
valhalla-change-match
branch
from
e5e79ff to
81be944
Compare
|
@theresa-m done with the changes in the issue description and commit body |
Replace Unsafe.arrayLayout(Class<?> arrayClass) with Unsafe.arrayLayout(Object[] array) to match the Valhalla changes. Update the Valhalla functional test to use the updated method signature. Fixes: eclipse-openj9#24249 Signed-off-by: Konark Shah <Konarkshah2010@gmail.com>
konark2010
force-pushed
the
valhalla-change-match
branch
from
c331a01 to
0d387fe
Compare
|
Jenkins test sanity.functional,extended zlinuxval jdknext |
|
@konark2010 The PR build failed. |
will look onto it but it is strange as the personal build was passing |
Your personal build runs sanity.functional tests only. The PR build fails at extended.functional tests. |
|
Those failures are related to #23827 |
OK, good to know. Pls open an issue for that. |
3 participants
Replace Unsafe.arrayLayout(Class<?>) with arrayLayout(Object[]) and updated its usage to align with the change
Fixes: #24249
This PR has to be aligned with this PR to avoid failures