Use value-based hashing and equality for JVMTI object tags#24354
Draft
harship04 wants to merge 1 commit into
Draft
Use value-based hashing and equality for JVMTI object tags#24354harship04 wants to merge 1 commit into
harship04 wants to merge 1 commit into
Conversation
In hashObjectTag, use convertObjectToHash to hash value types by their contents. In hashEqualObjectTag, use valueTypeCapableAcmp to compare value types by value, allowing equivalent value objects to resolve to the same object tag.
hangshao0
reviewed
Jul 13, 2026
| j9object_t ref = ((J9JVMTIObjectTag *)entry)->ref; | ||
|
|
||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | ||
| if ((NULL != userData) && (NULL != ref)) { |
| goto fail; | ||
| } | ||
| j9env->objectTagTable = hashTableNew(OMRPORT_FROM_J9PORT(vm->portLibrary), J9_GET_CALLSITE(), 0, sizeof(J9JVMTIObjectTag), sizeof(jlong), 0, J9MEM_CATEGORY_JVMTI, hashObjectTag, hashEqualObjectTag, NULL, NULL); | ||
| j9env->objectTagTable = hashTableNew(OMRPORT_FROM_J9PORT(vm->portLibrary), J9_GET_CALLSITE(), 0, sizeof(J9JVMTIObjectTag), sizeof(jlong), 0, J9MEM_CATEGORY_JVMTI, hashObjectTag, hashEqualObjectTag, NULL, vm); |
Contributor
There was a problem hiding this comment.
vm is only needed if J9VM_OPT_VALHALLA_VALUE_TYPES is defined.
| } | ||
|
|
||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | ||
| if ((NULL != userData) && (NULL != lhsRef) && (NULL != rhsRef)) { |
hangshao0
added
comp:jvmti
project:valhalla
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix related to issue:#24134
In hashObjectTag, use convertObjectToHash to hash value types by
their contents. In hashEqualObjectTag, use valueTypeCapableAcmp
to compare value types by value, allowing equivalent value objects to resolve
to the same object tag.