feat: Add a bulk publisher revocation endpoint (#1860)

* feat: Add a bulk publisher revocation endpoint

This endpoint, using the admin access token as authentication, allows for multiple publishers to be unpublished simulataneously. This additionally adds optional support for adding a reason to the audit log for revoking publisher contributions.

Resolves EclipseFdn/open-vsx.org#10109

* feat: Update publisher revoke to remove namespace memberships

To ensure full removal of revoked publishers, removal of namespace
memberships was added to the publisher revocation flow.

* fix: Update publisher revocation to not function on admins

As a new guard rail, any publishers that are also admins pushed for
revocation via the API gets rejected and must first have their admin
role revoked.

* fix: Add missing deleteMemberships call in RepositoryService smoke test

* fix: Cleanup metadata around bulk revoke, add limits, move logic to admins service

* fix: Add provider to the key for bulk publisher results

* move eclipse ignores to top-level

* fix formatting, move method to API due to transactional self-invocation

* adjust tests

* fix test

---------

Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
Co-authored-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>

Author: autumnfound

.gitignore

@@ -1,2 +1,4 @@
 .idea/
+.project/
+.settings/
 data/

server/.gitignore

@@ -3,9 +3,7 @@
 
 .gradle/
 .idea/
-.settings/
 .classpath
-.project
 .metals
 .bloop
 

server/src/main/java/org/eclipse/openvsx/admin/AdminAPI.java

@@ -20,6 +20,7 @@
 import java.time.ZoneId;
 import java.util.ArrayList;
 import java.util.Comparator;
+import java.util.HashMap;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Objects;
@@ -40,6 +41,8 @@
 import org.eclipse.openvsx.entities.Namespace;
 import org.eclipse.openvsx.entities.PersonalAccessToken;
 import org.eclipse.openvsx.entities.UserData;
+import org.eclipse.openvsx.json.BulkPublisherRevokeRequestJson;
+import org.eclipse.openvsx.json.BulkPublisherRevokeResponseJson;
 import org.eclipse.openvsx.json.ChangeNamespaceJson;
 import org.eclipse.openvsx.json.ExtensionJson;
 import org.eclipse.openvsx.json.NamespaceJson;
@@ -536,6 +539,11 @@ public ResultJson updateUserRole(String provider, String loginName, String role,
 
     @Transactional(rollbackOn = ErrorResultException.class)
     public ResultJson revokePublisherContributions(String provider, String loginName, UserData admin) {
+        return revokePublisherContributions(provider, loginName, admin, null);
+    }
+
+    @Transactional(rollbackOn = ErrorResultException.class)
+    public ResultJson revokePublisherContributions(String provider, String loginName, UserData admin, String reason) {
         var user = repositories.findUserByLoginName(provider, loginName);
         if (user == null) {
             throw new ErrorResultException(userNotFoundMessage(loginName), HttpStatus.NOT_FOUND);
@@ -570,10 +578,25 @@ public ResultJson revokePublisherContributions(String provider, String loginName
         for (var extension : affectedExtensions) {
             extensions.updateExtension(extension);
         }
+        
+        // revoke namespace memberships
+        var namespaceMemberships = repositories.findMemberships(user);
+        var numberOfNamespaceMemberships = 0L;
+        // add a null check due to tests using mocks which return null
+        if (namespaceMemberships != null) {
+            numberOfNamespaceMemberships = namespaceMemberships.stream().count();
+            repositories.deleteMemberships(user);
+        }
+
+        var message = "Deactivated " + deactivatedTokenCount + " tokens, "
+            + "deactivated " + deactivatedExtensionCount + " extensions, "
+            + "removed " + numberOfNamespaceMemberships + " namespace memberships of user "
+            + provider + "/" + loginName + ".";
 
-        var result = ResultJson.success("Deactivated " + deactivatedTokenCount
-                + " tokens, deactivated " + deactivatedExtensionCount + " extensions of user "
-                + provider + "/" + loginName + ".");
+        if (reason != null) {
+            message += " Reason: " + reason;
+        }
+        var result = ResultJson.success(message);
         logs.logAction(admin, result);
         return result;
     }

server/src/main/java/org/eclipse/openvsx/admin/AdminService.java

@@ -0,0 +1,32 @@
+/******************************************************************************
+ * Copyright (c) 2026 Contributors to the Eclipse Foundation.
+ *
+ * See the NOTICE file(s) distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * https://www.eclipse.org/legal/epl-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *****************************************************************************/
+package org.eclipse.openvsx.json;
+
+import java.util.List;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+
+/**
+ * Used to revoke publishers in bulk
+ */
+@Schema(
+    name = "BulkPublisherRevokeRequest",
+    description = "List of publishers to revoke contributions for"
+)
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public record BulkPublisherRevokeRequestJson(
+    List<PublisherRevocationTargetJson> publishers,
+    String reason
+) {}

server/src/main/java/org/eclipse/openvsx/json/BulkPublisherRevokeRequestJson.java

@@ -0,0 +1,55 @@
+/******************************************************************************
+ * Copyright (c) 2026 Contributors to the Eclipse Foundation.
+ *
+ * See the NOTICE file(s) distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * https://www.eclipse.org/legal/epl-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *****************************************************************************/
+package org.eclipse.openvsx.json;
+
+import java.util.Map;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+
+/**
+ * Response for the request to bulk revoke publishers
+ */
+@Schema(
+    name = "BulkPublisherRevokeResponse",
+    description = "List of responses for the bulk publisher revocation request"
+)
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public class BulkPublisherRevokeResponseJson extends ResultJson {
+
+    public static BulkPublisherRevokeResponseJson error(String message) {
+        var result = new BulkPublisherRevokeResponseJson();
+        result.setError(message);
+        return result;
+    }
+
+    @Schema(description = "Results for each of the attempted revoke operations matched on the login name of the user")
+    private Map<String, ResultJson> responses;
+
+    public BulkPublisherRevokeResponseJson() {
+        this.responses = null;
+    }
+
+    public BulkPublisherRevokeResponseJson(Map<String, ResultJson> responses) {
+        this.responses = responses;
+    }
+
+    public void setResponses(Map<String, ResultJson> responses) {
+        this.responses = responses;
+    }
+
+    public Map<String, ResultJson> getResponses() {
+        return this.responses;
+    }
+}

server/src/main/java/org/eclipse/openvsx/json/BulkPublisherRevokeResponseJson.java

@@ -0,0 +1,27 @@
+/******************************************************************************
+ * Copyright (c) 2026 Contributors to the Eclipse Foundation.
+ *
+ * See the NOTICE file(s) distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * https://www.eclipse.org/legal/epl-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0
+ *****************************************************************************/
+package org.eclipse.openvsx.json;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+
+@Schema(
+    name = "PublisherRevocationTarget",
+    description = "Coordinate for a publisher that should be have its' contributions revoked"
+)
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public record PublisherRevocationTargetJson(
+        String loginName,
+        String provider
+) {}

server/src/main/java/org/eclipse/openvsx/json/PublisherRevocationTargetJson.java

@@ -26,4 +26,6 @@ public interface NamespaceMembershipRepository extends Repository<NamespaceMembe
     Streamable<NamespaceMembership> findByUserOrderByNamespaceName(UserData user);
 
     NamespaceMembership findFirstByNamespaceNameIgnoreCase(String namespaceName);
+    
+    void deleteByUser(UserData user);
 }

server/src/main/java/org/eclipse/openvsx/repositories/NamespaceMembershipRepository.java

@@ -376,6 +376,10 @@ public Page<UserData> searchUsers(String search, String role, Pageable pageable)
     public NamespaceMembership findMembership(UserData user, Namespace namespace) {
         return membershipRepo.findByUserAndNamespace(user, namespace);
     }
+    
+    public void deleteMemberships(UserData user) {
+        membershipRepo.deleteByUser(user);
+    }
 
     public boolean hasMembership(UserData user, Namespace namespace) {
         return membershipJooqRepo.hasMembership(user, namespace);