Skip to content

Commit 1b69cee

Browse files
committed
feat(changes): use uppercase for state enum values
1 parent e92c13d commit 1b69cee

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1167,7 +1167,7 @@ public ChangesResultJson getChanges(LocalDateTime since, LocalDateTime before, i
11671167
entry.setName(ev.getExtension().getName());
11681168
entry.setVersion(ev.getVersion());
11691169
entry.setTargetPlatform(ev.getTargetPlatform());
1170-
entry.setState(ev.getState().name().toLowerCase());
1170+
entry.setState(ev.getState().name());
11711171
entry.setTimestamp(TimeUtil.toUTCString(ev.getTimestamp()));
11721172
entry.setLastUpdated(TimeUtil.toUTCString(ev.getLastUpdated()));
11731173
entry.setExtension(ev.toExtensionJson());

server/src/main/java/org/eclipse/openvsx/entities/ExtensionVersion.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,11 +323,10 @@ public void setPublishedWith(PersonalAccessToken publishedWith) {
323323
}
324324

325325
public boolean isActive() {
326-
return active;
326+
return state == State.ACTIVE;
327327
}
328328

329329
public void setActive(boolean active) {
330-
this.active = active;
331330
setState(active ? State.ACTIVE : State.INACTIVE);
332331
}
333332

@@ -336,6 +335,7 @@ public State getState() {
336335
}
337336

338337
public void setState(State state) {
338+
this.active = state == State.ACTIVE;
339339
this.state = state;
340340
this.lastUpdated = TimeUtil.getCurrentUTC();
341341
}

server/src/test/java/org/eclipse/openvsx/RegistryAPITest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1918,7 +1918,7 @@ void testGetChanges() throws Exception {
19181918
entry.setName("bar");
19191919
entry.setVersion("1.0.0");
19201920
entry.setTargetPlatform(TargetPlatform.NAME_UNIVERSAL);
1921-
entry.setState("active");
1921+
entry.setState("ACTIVE");
19221922
entry.setTimestamp("2000-01-01T10:00Z");
19231923
entry.setLastUpdated("2000-01-01T10:00Z");
19241924
c.setOffset(0);
@@ -1953,7 +1953,7 @@ void testGetChangesInactiveVersion() throws Exception {
19531953
.andExpect(status().isOk())
19541954
.andExpect(content().json(changesJson(c -> {
19551955
var entry = new ChangeEntryJson();
1956-
entry.setState("inactive");
1956+
entry.setState("INACTIVE");
19571957
c.setTotalSize(1);
19581958
c.setChanges(List.of(entry));
19591959
})));

0 commit comments

Comments
 (0)