refactor to SettingsService in package settings

Author: netomi

server/src/main/java/org/eclipse/openvsx/RegistryAPI.java

@@ -20,7 +20,7 @@
 import jakarta.servlet.http.HttpServletRequest;
 import org.apache.commons.lang3.StringUtils;
 import org.eclipse.openvsx.entities.SemanticVersion;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.*;
 import org.eclipse.openvsx.search.ISearchService;
 import org.eclipse.openvsx.search.SortBy;

server/src/main/java/org/eclipse/openvsx/UserAPI.java

@@ -13,7 +13,7 @@
 import org.eclipse.openvsx.accesstoken.AccessTokenService;
 import org.eclipse.openvsx.eclipse.EclipseService;
 import org.eclipse.openvsx.entities.*;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.*;
 import org.eclipse.openvsx.repositories.ExtensionScanRepository;
 import org.eclipse.openvsx.repositories.RepositoryService;

server/src/main/java/org/eclipse/openvsx/adapter/VSCodeAPI.java

@@ -35,10 +35,8 @@
 import org.springframework.web.servlet.mvc.method.annotation.StreamingResponseBody;
 
 import java.util.List;
-import java.util.Optional;
 import java.util.concurrent.TimeUnit;
 
-import static org.eclipse.openvsx.adapter.ExtensionQueryParam.*;
 import static org.eclipse.openvsx.adapter.ExtensionQueryResult.ExtensionFile.*;
 import static org.eclipse.openvsx.util.TargetPlatform.*;
 

server/src/main/java/org/eclipse/openvsx/admin/AdminAPI.java

@@ -21,7 +21,7 @@
 import org.eclipse.openvsx.entities.AdminStatistics;
 import org.eclipse.openvsx.entities.NamespaceMembership;
 import org.eclipse.openvsx.entities.PersistedLog;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.AdminStatisticsJson;
 import org.eclipse.openvsx.json.ChangeNamespaceJson;
 import org.eclipse.openvsx.json.ExtensionJson;

server/src/main/java/org/eclipse/openvsx/admin/FileDecisionAPI.java

@@ -18,7 +18,7 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import org.eclipse.openvsx.entities.FileDecision;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.*;
 import org.eclipse.openvsx.repositories.RepositoryService;
 import org.eclipse.openvsx.util.ErrorResultException;

server/src/main/java/org/eclipse/openvsx/admin/RateLimitAPI.java

@@ -13,7 +13,7 @@
 package org.eclipse.openvsx.admin;
 
 import org.eclipse.openvsx.entities.*;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.*;
 import org.eclipse.openvsx.ratelimit.CustomerService;
 import org.eclipse.openvsx.ratelimit.cache.RateLimitCacheService;

server/src/main/java/org/eclipse/openvsx/admin/ScanAPI.java

@@ -23,7 +23,7 @@
 import jakarta.annotation.Nonnull;
 import jakarta.annotation.Nullable;
 import org.eclipse.openvsx.entities.*;
-import org.eclipse.openvsx.featureflag.MutatingOperation;
+import org.eclipse.openvsx.settings.MutatingOperation;
 import org.eclipse.openvsx.json.*;
 import org.eclipse.openvsx.repositories.RepositoryService;
 import org.eclipse.openvsx.storage.StorageUtilService;

…envsx/featureflag/MutatingOperation.java …/openvsx/settings/MutatingOperation.javaserver/src/main/java/org/eclipse/openvsx/featureflag/MutatingOperation.java renamed to server/src/main/java/org/eclipse/openvsx/settings/MutatingOperation.java server/src/main/java/org/eclipse/openvsx/featureflag/MutatingOperation.java renamed to server/src/main/java/org/eclipse/openvsx/settings/MutatingOperation.java

@@ -10,10 +10,13 @@
  *
  * SPDX-License-Identifier: EPL-2.0
  *****************************************************************************/
-package org.eclipse.openvsx.featureflag;
+package org.eclipse.openvsx.settings;
 
 import java.lang.annotation.*;
 
+/**
+ * A marker annotation to indicate an operation that mutates the DB.
+ */
 @Target(ElementType.METHOD)
 @Retention(RetentionPolicy.RUNTIME)
 @Documented

…/featureflag/ReadOnlyEndpointAspect.java …vsx/settings/ReadOnlyEndpointAspect.javaserver/src/main/java/org/eclipse/openvsx/featureflag/ReadOnlyEndpointAspect.java renamed to server/src/main/java/org/eclipse/openvsx/settings/ReadOnlyEndpointAspect.java server/src/main/java/org/eclipse/openvsx/featureflag/ReadOnlyEndpointAspect.java renamed to server/src/main/java/org/eclipse/openvsx/settings/ReadOnlyEndpointAspect.java

@@ -10,7 +10,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0
  *****************************************************************************/
-package org.eclipse.openvsx.featureflag;
+package org.eclipse.openvsx.settings;
 
 import org.aspectj.lang.ProceedingJoinPoint;
 import org.aspectj.lang.annotation.Around;
@@ -23,21 +23,17 @@
 @Component
 public class ReadOnlyEndpointAspect {
 
-    private final FeatureFlagService featureFlagService;
+    private final SettingsService settingsService;
 
-    public ReadOnlyEndpointAspect(FeatureFlagService featureFlagService) {
-        this.featureFlagService = featureFlagService;
+    public ReadOnlyEndpointAspect(SettingsService settingsService) {
+        this.settingsService = settingsService;
     }
 
     @Around("(execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.RegistryAPI.*(..)) ||" +
-            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.admin.AdminAPI.*(..)) ||" +
-            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.admin.FileDecisionAPI.*(..)) ||" +
-            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.admin.RateLimitAPI.*(..)) ||" +
-            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.admin.ScanAPI.*(..)) ||" +
-            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.UserAPI.*(..))) &&" +
-            "@annotation(MutatingOperation)")
+            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.UserAPI.*(..))  ||" +
+            " execution(org.springframework.http.ResponseEntity org.eclipse.openvsx.admin.*API.*(..))) && @annotation(MutatingOperation)")
     public Object handleMutatingEndpoint(ProceedingJoinPoint joinPoint) throws Throwable {
-        if (featureFlagService.isRegistryReadOnly()) {
+        if (settingsService.isRegistryReadOnly()) {
             return ResponseEntity.status(409).body(ResultJson.error("Registry is in read-only mode."));
         } else {
             return joinPoint.proceed();

…nvsx/featureflag/FeatureFlagService.java …se/openvsx/settings/SettingsService.javaserver/src/main/java/org/eclipse/openvsx/featureflag/FeatureFlagService.java renamed to server/src/main/java/org/eclipse/openvsx/settings/SettingsService.java server/src/main/java/org/eclipse/openvsx/featureflag/FeatureFlagService.java renamed to server/src/main/java/org/eclipse/openvsx/settings/SettingsService.java

@@ -10,14 +10,14 @@
  *
  * SPDX-License-Identifier: EPL-2.0
  *****************************************************************************/
-package org.eclipse.openvsx.featureflag;
+package org.eclipse.openvsx.settings;
 
 import org.springframework.stereotype.Service;
 
 @Service
-public class FeatureFlagService {
+public class SettingsService {
 
-    public FeatureFlagService() {}
+    public SettingsService() {}
 
     public boolean isRegistryReadOnly() {
         // TODO: implement this