Feat: Add read only mode#1835
Merged
Merged
Conversation
netomi
added
the
snapshot
Contributor
Author
|
Read-only mode is functional, missing:
|
netomi
force-pushed
the
read-only-mode
branch
2 times, most recently
from
b071baa to
e646b3a
Compare
…ration annotation to indicate endpoint that modify the DB, add annotation to all relevant endpoints
…on timeout, add label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dynamic read-only mode to Open VSX.
The idea is that dynamically at runtime via the admin dashboard, you can set the registry in read-only mode, i.e. all requests that would modify the DB are rejected with a
409response indicating the reason.This can be achieved with an aspect that matches any endpoint that is annotated with the
MutatingOperationannotation.Apart from all mutating endpoints that are disabled, recurring jobs also check for the read-only status.
Exception are jobs wrt the scanning infrastructure, as it is better to finish running scans to keep a consistent state. No new scan jobs should be added after the registry is set to read-only.
So for migration the process would be as follows:
This also fixes #1804 by bumping to a more recent jedis version