fix: cache S3Presigner as singleton to prevent IRSA credential refresh failure#1856
Merged
Merged
Conversation
…lure The S3Presigner was created fresh on every getLocation() call and immediately closed via try-with-resources. Closing the presigner shuts down the underlying HTTP connection pool used by DefaultCredentialsProvider for STS token refresh. After ~63 minutes when IRSA credentials expire, the next presign attempt fails because the connection pool is dead. Fix: Cache the S3Presigner as a singleton field (same pattern as S3Client). The presigner stays open for the lifetime of the application, allowing DefaultCredentialsProvider to refresh IRSA tokens via its internal HTTP client without interruption. Fixes: eclipse-openvsx#1855 Signed-off-by: Adnan Al <98621989+achdmbp@users.noreply.github.com>
netomi
force-pushed
the
fix/s3-presigner-lifecycle
branch
from
60135ec to
10519ec
Compare
Contributor
|
I protected the lazy initialization with double-checked locking and avoided code duplication. Also the objects are closed properly. Please check on your side, the changes look fine to me otherwise. |
svor
approved these changes
May 25, 2026
Contributor
|
@achdmbp could you please double-check whether the problem is fixed with the current changes? |
netomi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1855
The
S3Presignerwas created and closed on everygetLocation()call via try-with-resources. Closing the presigner destroys the HTTP connection pool thatDefaultCredentialsProviderneeds to refresh IRSA credentials via STS. After ~63 minutes when credentials expire, all presign operations fail with 500 errors.This change caches the
S3Presigneras a singleton field, matching the existing pattern used forS3Client. The presigner stays open for the application's lifetime, allowing credential refresh to work indefinitely.Changes
S3Presigneras a singleton field (lazy initialization)getLocation()since presigner is now long-livedTesting
AwsStorageServiceTest)