Skip to content

chore(webui): upgrade React to v19 and React Router to v7/v8#1930

Closed
vinokurig wants to merge 1 commit into
eclipse-openvsx:mainfrom
vinokurig:CVE-2026-42342
Closed

chore(webui): upgrade React to v19 and React Router to v7/v8#1930
vinokurig wants to merge 1 commit into
eclipse-openvsx:mainfrom
vinokurig:CVE-2026-42342

Conversation

@vinokurig

Copy link
Copy Markdown
Contributor

Upgrade react-router and react-router-dom from 6.30.4 to 7.18.1 to address CVE-2026-42342.

@netomi

netomi commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

the project still uses v6.x of react/router and should thus not be affected by that CVE:

image

it is also not listed in the dependabot vulnerability tab

@netomi netomi requested a review from gnugomez June 30, 2026 13:53
@netomi

netomi commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@gnugomez can you take a look here and assess whether the upgrade to the react/router 7+ is doable.

@gnugomez

gnugomez commented Jun 30, 2026

Copy link
Copy Markdown
Member

@netomi even if we where in the vulnerable version our app uses BrowserRouter so this would should not affect us https://github.com/gnugomez/openvsx/blob/f025e3d0259b4461e5b2ef64d2415c558f1e68fc/webui/src/default/default-app.tsx#L73-L75

This does not impact your React Router application if you are using Declarative Mode <BrowserRouter> or Data Mode (createBrowserRouter/<RouterProvider>).

Although it's valuable to keep react-router up to date, but since we're taking the time to do so, why not it's latest major? right now the latest version is v8.1.0

https://reactrouter.com/7.18.1/upgrading/v6
https://reactrouter.com/upgrading/v7

@vinokurig

Copy link
Copy Markdown
Contributor Author

@gnugomez

Although it's valuable to keep react-router up to date, but since we're taking the time to do so, why not it's latest major? right now the latest version is v8.1.0

done, updated to the latest version

@netomi

netomi commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

we cant update to v8 as the minimum required react version is stated as:

react@19.2.7+/react-dom@19.2.7+

while we are at 18.3.1 still.

@vinokurig vinokurig force-pushed the CVE-2026-42342 branch 2 times, most recently from ace930a to 505a98b Compare June 30, 2026 15:53
@vinokurig

Copy link
Copy Markdown
Contributor Author

right, reverted to the latest v7 version

@gnugomez

gnugomez commented Jul 1, 2026

Copy link
Copy Markdown
Member

yeah that's right... for updating to v7 I need to check but I believe we need to update some imports

@netomi

netomi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

it would make sense though to start updating to a more recent react version, active support for react 18 stopped a long time ago: https://endoflife.date/react

they still provide security updates though.

Upgrade core dependencies to address CVE-2026-42342.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@vinokurig vinokurig changed the title chore(webui): upgrade react-router to v7 chore(webui): upgrade React to v19 and React Router to v7/v8 Jul 1, 2026
@netomi

netomi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

sorry if you misunderstood my comment. I was not asking you to upgrade to react 19 which we cant do just like that.

That will have to be properly tested and planned, and after some more discussions we are probably not be doing that soon.

@vinokurig

vinokurig commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@netomi Sorry, I am a little bit confused, would it be ok if I just update react-router to v7?

@netomi

netomi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

I dont get it that we need to update react/router as our version is not affected by the referenced CVE.

Updating to v7 will require testing as there are breaking changes that affect us afaict from the release notes

@vinokurig

Copy link
Copy Markdown
Contributor Author

@netomi @gnugomez Since the project is not affected by the CVE, I would like to close the pull request, do you have any objections?

@netomi

netomi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

fine by me, we are working on a redesign of the app and that would be a good place to also update the router to v7

@vinokurig vinokurig closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants