BundleContextExtension does not check for null

[laeubi]

If the bundles are not started that are used to acquire the bundle-context then null is used internally leading to NPE in BundleContextExtension.

[stbischof]

How do you install the bundle?

• Using BundleContext
• BundleInstaller
• injectBundle Annotation

With Junit 4 or 5

If you have an repo with an example it would help me to find the problem.

[laeubi]

I have not yet tried junit4 but it might be similar there. from my setup I would assume that the problem arises if:

1. the junit5 bundles are resolved but not started
2. the bundle containing the test is resolved but not started

org.osgi.test.junit5.context.BundleContextExtension.getBundleContext(ExtensionContext) uses the testclass to find the bundlecontext for the test class first, if that is not present it uses org.osgi.test.junit5.context.BundleContextExtension.getParentBundleContext(ExtensionContext)

If both of them are null, a null context is passed.

[stbischof]

Could you please give me a repo /example where i can reproduce it?

The position in code is clearer but i am not able to reproduce it.

https://github.com/osgi/osgi-test/blob/fffc8a786f5d21c6be1f1c04386d90fb6f593e87/org.osgi.test.junit5/src/main/java/org/osgi/test/junit5/context/BundleContextExtension.java#L167-L184

[rotty3000]

Could you provide a case that reproduces the issue? A small git project would be ideal. Thank you.

…

On Tue., Apr. 6, 2021, 2:33 a.m. Christoph Läubrich, < ***@***.***> wrote: I have not yet tried junit4 but it might be similar there. from my setup I would assume that the problem arises if: 1. the junit5 bundles are resolved but not started 2. the bundle containing the test is resolved but not started org.osgi.test.junit5.context.BundleContextExtension.getBundleContext(ExtensionContext) uses the testclass to find the bundlecontext for the test class first, if that is not present it uses org.osgi.test.junit5.context.BundleContextExtension.getParentBundleContext(ExtensionContext) If both of them are null, a null context is passed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABD2TDSIGEFGCX5ZVG6ZATTHKTLDANCNFSM42OAXKRQ> .

[bjhargrave]

I am going to close this since no reproduction was made available.

[laeubi]

I am going to close this since no reproduction was made available.

It is rather obvious that there could be a NPE but its hard to reproduce since only BND setup is "supported" but just for the sake of reproduction simply create a plain surefire Junit5 test and have the following test-class:

@ExtendWith(BundleContextExtension.class)
public class BasicTest {

	@InjectBundleContext
	BundleContext bc;

	@Test
	@DisplayName("Test BundleContext injection")
	void myTest() {
		System.out.println("The injected bc is " + bc);
	}
}

Just note: running it with plain surefire will always fail as it is not running inside an OSGi container! But it should not fail with an NPE but something more descriptive e.g. neither test-bundle nor parent context could be adapted to a Bundle Context, are all bundles resolved and started?

[rotty3000]

Right, the issue here is that this is not running under OSGi test. I suppose we should clarify that this framework is intended to be used in an OSGi integration test under a running OSGi framework. Surefire is not (yet) supported.

…

On Mon., Mar. 28, 2022, 5:36 a.m. Christoph Läubrich, < ***@***.***> wrote: I am going to close this since no reproduction was made available. It is rather obvious that there could be a NPE but its hard to reproduce since only BND setup is "supported" but just for the sake of reproduction simply create a plain surefire Junit5 test and have the following test-class: @ExtendWith(BundleContextExtension.class) public class BasicTest { @InjectBundleContext BundleContext bc; @test @DisplayName("Test BundleContext injection") void myTest() { System.out.println("The injected bc is " + bc); } } *Just note*: running it with plain surefire will *always* fail as it is not running inside an OSGi container! But it should not fail with an NPE but something more descriptive e.g. neither test-bundle nor parent context could be adapted to a Bundle Context, are all bundles resolved and started? — Reply to this email directly, view it on GitHub <#302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABD2THNCF336UQIB7DH5G3VCF4Q3ANCNFSM42OAXKRQ> . You are receiving this because you commented.Message ID: ***@***.***>

[laeubi]

Its jsut the easiest way to get the NPE it also happens when the test-bundle is not started (as then there is not BundleContext).

[kriegfrj]

You would have to jump through hoops to get a the test class from the bundle to be running while the bundle it belongs to is stopped. Mind you, if you can come up with a simple way to trigger this I would be greatly appreciated, because the patch I put together for this feature in #500 doesn't have a regression test (precisely because of the hoops I thought I would need to jump through) and I would like it to have a proper regression test.

[laeubi]

if you can come up with a simple way to trigger this I would be greatly appreciated

Sure, I'm currently trying to setup a simple standalone project using osgi-test but it seems it is not even trivial to have a minimal project without a lot of config and dependencies so it seems quite hard to use osgi-test without full bnd workflow.

[rotty3000]

I guess we could work on the docs first before trying to fix anything here because I feel we have more than enough proof that things work the way we intended, 'cept it's hard for beginners. Some of the assumptions (there are a few) should certainly be clarified.

[kriegfrj]

if you can come up with a simple way to trigger this I would be greatly appreciated

Sure, I'm currently trying to setup a simple standalone project using osgi-test but it seems it is not even trivial to have a minimal project without a lot of config and dependencies so it seems quite hard to use osgi-test without full bnd workflow.

That's because osgi-test is designed to be run inside a running OSGi framework, and it's hard to launch a running OSGi framework from within Maven unless you use the full bnd workflow. Possible exceptions to this are the AssertJ bundles and the commons bundle.

If you're not using Bnd to launch your OSGi framework, how are you launching one? Are you launching one? If you're not launching one there's probably not much we can do to help, but if you are launching one using some other workflow it's possible that we might be able to accommodate it.