Skip to content

Commit 6463df9

Browse files
committed
Fixed doxygen warnings for missing params, etc, and for obsolete tags
1 parent c0b43a4 commit 6463df9

10 files changed

Lines changed: 18 additions & 93 deletions

File tree

doc/Doxyfile.cmake

Lines changed: 2 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -195,13 +195,6 @@ TAB_SIZE = 4
195195

196196
ALIASES =
197197

198-
# This tag can be used to specify a number of word-keyword mappings (TCL only).
199-
# A mapping has the form "name=value". For example adding
200-
# "class=itcl::class" will allow you to use the command class in the
201-
# itcl::class meaning.
202-
203-
TCL_SUBST =
204-
205198
# Set the OPTIMIZE_OUTPUT_FOR_C tag to YES if your project consists of C
206199
# sources only. Doxygen will then generate output that is more tailored for C.
207200
# For instance, some of the names that are used will be different. The list
@@ -833,12 +826,6 @@ VERBATIM_HEADERS = YES
833826

834827
ALPHABETICAL_INDEX = YES
835828

836-
# If the alphabetical index is enabled (see ALPHABETICAL_INDEX) then
837-
# the COLS_IN_ALPHA_INDEX tag can be used to specify the number of columns
838-
# in which this list will be split (can be a number in the range [1..20])
839-
840-
COLS_IN_ALPHA_INDEX = 5
841-
842829
# In case all classes in a project start with a common prefix, all
843830
# classes will be put under the same header in the alphabetical index.
844831
# The IGNORE_PREFIX tag can be used to specify one or more prefixes that
@@ -929,12 +916,6 @@ HTML_COLORSTYLE_SAT = 100
929916

930917
HTML_COLORSTYLE_GAMMA = 80
931918

932-
# If the HTML_TIMESTAMP tag is set to YES then the footer of each generated HTML
933-
# page will contain the date and time when the page was generated. Setting
934-
# this to NO can help when comparing the output of multiple runs.
935-
936-
HTML_TIMESTAMP = YES
937-
938919
# If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes,
939920
# files or namespaces will be aligned in HTML using tables. If set to
940921
# NO a bullet list will be used.
@@ -1151,14 +1132,6 @@ EXT_LINKS_IN_WINDOW = NO
11511132

11521133
FORMULA_FONTSIZE = 10
11531134

1154-
# Use the FORMULA_TRANPARENT tag to determine whether or not the images
1155-
# generated for formulas are transparent PNGs. Transparent PNGs are
1156-
# not supported properly for IE 6.0, but are supported on all modern browsers.
1157-
# Note that when changing this option you need to delete any form_*.png files
1158-
# in the HTML output before the changes have effect.
1159-
1160-
FORMULA_TRANSPARENT = YES
1161-
11621135
# Enable the USE_MATHJAX option to render LaTeX formulas using MathJax
11631136
# (see http://www.mathjax.org) which uses client side Javascript for the
11641137
# rendering instead of using prerendered bitmaps. Use this if you do not
@@ -1290,13 +1263,6 @@ LATEX_BATCHMODE = NO
12901263

12911264
LATEX_HIDE_INDICES = NO
12921265

1293-
# If LATEX_SOURCE_CODE is set to YES then doxygen will include
1294-
# source code with syntax highlighting in the LaTeX output.
1295-
# Note that which sources are shown also depends on other settings
1296-
# such as SOURCE_BROWSER.
1297-
1298-
LATEX_SOURCE_CODE = NO
1299-
13001266
# The LATEX_BIB_STYLE tag can be used to specify the style to use for the
13011267
# bibliography, e.g. plainnat, or ieeetr. The default style is "plain". See
13021268
# http://en.wikipedia.org/wiki/BibTeX for more info.
@@ -1561,32 +1527,10 @@ ALLEXTERNALS = NO
15611527

15621528
EXTERNAL_GROUPS = YES
15631529

1564-
# The PERL_PATH should be the absolute path and name of the perl script
1565-
# interpreter (i.e. the result of `which perl').
1566-
1567-
PERL_PATH = /usr/bin/perl
1568-
15691530
#---------------------------------------------------------------------------
15701531
# Configuration options related to the dot tool
15711532
#---------------------------------------------------------------------------
15721533

1573-
# If the CLASS_DIAGRAMS tag is set to YES (the default) Doxygen will
1574-
# generate a inheritance diagram (in HTML, RTF and LaTeX) for classes with base
1575-
# or super classes. Setting the tag to NO turns the diagrams off. Note that
1576-
# this option also works with HAVE_DOT disabled, but it is recommended to
1577-
# install and use dot, since it yields more powerful graphs.
1578-
1579-
CLASS_DIAGRAMS = YES
1580-
1581-
# You can define message sequence charts within doxygen comments using the \msc
1582-
# command. Doxygen will then run the mscgen tool (see
1583-
# http://www.mcternan.me.uk/mscgen/) to produce the chart and insert it in the
1584-
# documentation. The MSCGEN_PATH tag allows you to specify the directory where
1585-
# the mscgen tool resides. If left empty the tool is assumed to be found in the
1586-
# default search path.
1587-
1588-
MSCGEN_PATH =
1589-
15901534
# If set to YES, the inheritance and collaboration graphs will hide
15911535
# inheritance and usage relations if the target is undocumented
15921536
# or is not a class.
@@ -1608,22 +1552,8 @@ HAVE_DOT = NO
16081552

16091553
DOT_NUM_THREADS = 0
16101554

1611-
# By default doxygen will use the Helvetica font for all dot files that
1612-
# doxygen generates. When you want a differently looking font you can specify
1613-
# the font name using DOT_FONTNAME. You need to make sure dot is able to find
1614-
# the font, which can be done by putting it in a standard location or by setting
1615-
# the DOTFONTPATH environment variable or by setting DOT_FONTPATH to the
1616-
# directory containing the font.
1617-
1618-
DOT_FONTNAME = Helvetica
1619-
1620-
# The DOT_FONTSIZE tag can be used to set the size of the font of dot graphs.
1621-
# The default size is 10pt.
1622-
1623-
DOT_FONTSIZE = 10
1624-
1625-
# By default doxygen will tell dot to use the Helvetica font.
1626-
# If you specify a different font using DOT_FONTNAME you can use DOT_FONTPATH to
1555+
# By default doxygen will tell dot to use the default font.
1556+
# If you want a different font you can use DOT_FONTPATH to
16271557
# set the path where dot can find it.
16281558

16291559
DOT_FONTPATH =
@@ -1754,14 +1684,6 @@ DOT_GRAPH_MAX_NODES = 50
17541684

17551685
MAX_DOT_GRAPH_DEPTH = 0
17561686

1757-
# Set the DOT_TRANSPARENT tag to YES to generate images with a transparent
1758-
# background. This is disabled by default, because dot on Windows does not
1759-
# seem to support this out of the box. Warning: Depending on the platform used,
1760-
# enabling this option may lead to badly anti-aliased labels on the edges of
1761-
# a graph (i.e. they become hard to read).
1762-
1763-
DOT_TRANSPARENT = NO
1764-
17651687
# Set the DOT_MULTI_TARGETS tag to YES allow dot to generate multiple output
17661688
# files in one run (i.e. multiple -o and -T options on the command line). This
17671689
# makes dot run faster, but since only newer versions of dot (>1.8.10)

include/mqtt/async_client.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ class async_client : public virtual iasync_client
542542
* values are 0, 1 or 2.
543543
* @param retained whether or not this message should be retained by the
544544
* server.
545+
* @param props The MQTT v5 properties for the message.
545546
* @return token used to track and wait for the publish to complete. The
546547
* token will be passed to callback methods if set.
547548
*/
@@ -570,6 +571,7 @@ class async_client : public virtual iasync_client
570571
* values are 0, 1 or 2.
571572
* @param retained whether or not this message should be retained by the
572573
* server.
574+
* @param props The MQTT v5 properties for the message.
573575
* @return token used to track and wait for the publish to complete. The
574576
* token will be passed to callback methods if set.
575577
*/
@@ -806,15 +808,15 @@ class async_client : public virtual iasync_client
806808
* Determines if the consumer queue has been closed.
807809
* Once closed, any events in the queue can still be read, but no new
808810
* events can be added to it.
809-
* @return @true if the consumer queue has been closed, @false
811+
* @return @em true if the consumer queue has been closed, @em false
810812
* otherwise.
811813
*/
812814
bool consumer_closed() noexcept override { return !que_ || que_->closed(); }
813815
/**
814816
* Determines if the consumer queue is "done" (closed and empty).
815817
* Once the queue is done, no more events can be added or removed from
816818
* the queue.
817-
* @return @true if the consumer queue is closed and empty, @false
819+
* @return @em true if the consumer queue is closed and empty, @em false
818820
* otherwise.
819821
*/
820822
bool consumer_done() noexcept override { return !que_ || que_->done(); }

include/mqtt/client.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ class client : private callback
300300
/**
301301
* Subscribe to a topic, which may include wildcards using a QoS of 1.
302302
* @param topicFilter A single topic to subscribe
303-
maked * @param props The MQTT v5 properties.
304303
* @param opts The MQTT v5 subscribe options for the topic
304+
* @param props The MQTT v5 properties.
305305
* @return The "subscribe" response from the server.
306306
*/
307307
virtual subscribe_response subscribe(

include/mqtt/connect_options.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -702,8 +702,7 @@ class connect_options_builder
702702
}
703703
/**
704704
* Creates the default options for an MQTT v5 connection using
705-
* WebSockets
706-
* .
705+
* WebSockets.
707706
* The keepalive interval is set to 45 seconds to avoid webserver 60
708707
* second inactivity timeouts.
709708
*

include/mqtt/iasync_client.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ class iasync_client
203203
* values are 0, 1 or 2.
204204
* @param retained Whether or not this message should be retained by the
205205
* server.
206+
* @param props The MQTT v5 properties for the message.
206207
* @return token used to track and wait for the publish to complete. The
207208
* token will be passed to callback methods if set.
208209
*/
@@ -246,6 +247,7 @@ class iasync_client
246247
* values are 0, 1 or 2.
247248
* @param retained whether or not this message should be retained by the
248249
* server.
250+
* @param props The MQTT v5 properties for the message.
249251
* @return token used to track and wait for the publish to complete. The
250252
* token will be passed to callback methods if set.
251253
*/
@@ -459,15 +461,15 @@ class iasync_client
459461
* Determines if the consumer queue has been closed.
460462
* Once closed, any events in the queue can still be read, but no new
461463
* events can be added to it.
462-
* @return @true if the consumer queue has been closed, @false
464+
* @return @em true if the consumer queue has been closed, @em false
463465
* otherwise.
464466
*/
465467
virtual bool consumer_closed() noexcept { return false; }
466468
/**
467469
* Determines if the consumer queue is "done" (closed and empty).
468470
* Once the queue is done, no more events can be added or removed from
469471
* the queue.
470-
* @return @true if the consumer queue is closed and empty, @false
472+
* @return @em true if the consumer queue is closed and empty, @em false
471473
* otherwise.
472474
*/
473475
virtual bool consumer_done() noexcept { return false; }

include/mqtt/message.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,7 @@ inline message_ptr make_message(string_ref topic, const void* payload, size_t le
405405
* @param payload A buffer to use as the message payload.
406406
* @param qos The quality of service for the message.
407407
* @param retained Whether the message should be retained by the broker.
408+
* @param props The MQTT v5 properties for the message.
408409
*/
409410
inline message_ptr make_message(
410411
string_ref topic, binary_ref payload, int qos, bool retained,

include/mqtt/thread_queue.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ class thread_queue
185185
* Once closed, the queue will not accept any new items, but receievers
186186
* will still be able to get any remaining items out of the queue until
187187
* it is empty.
188-
* @return @em true if the queue is closed, @false otherwise.
188+
* @return @em true if the queue is closed, @em false otherwise.
189189
*/
190190
bool closed() const {
191191
guard g{lock_};
@@ -195,7 +195,7 @@ class thread_queue
195195
* Determines if all possible operations are done on the queue.
196196
* If the queue is closed and empty, then no further useful operations
197197
* can be done on it.
198-
* @return @true if the queue is closed and empty, @em false otherwise.
198+
* @return @em true if the queue is closed and empty, @em false otherwise.
199199
*/
200200
bool done() const {
201201
guard g{lock_};

include/mqtt/token.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ class token
381381
/**
382382
* Determines if the reference is valid.
383383
* If the reference is invalid then it is not safe to call @em any
384-
* member functions other than @ref is_null() and @ref empty()
384+
* member functions other than @em is_null() and @em empty()
385385
* @return @em true if referring to a valid buffer, @em false if the
386386
* reference (pointer) is null.
387387
*/

include/mqtt/topic.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ using const_topic_ptr = topic::const_ptr_t;
208208
*
209209
* This is simple class for individual topics. For a collection of topics
210210
* mapped to arbitrary values, like queues or callback functions, for
211-
* processing incoming messages, consider the @ref topic_mapper.
211+
* processing incoming messages, consider the @ref topic_matcher.
212212
*/
213213
class topic_filter
214214
{

include/mqtt/topic_matcher.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,7 @@ class topic_matcher
500500
}
501501
/**
502502
* Inserts a new value into the collection.
503-
* @param key The topic/filter entry
504-
* @param val The value to associate with that entry.
503+
* @param val The value to insert (topic/filter and associated value).
505504
*/
506505
void insert(const value_type& val) {
507506
value_type v{val};

0 commit comments

Comments
 (0)