fix potential deadlock in thread_queue#556
Closed
gferenc95 wants to merge 1 commit into
Closed
Conversation
- capacity setter notifies notFullCond to avoid deadlock on waiting for put - docstring
Contributor
|
Hey, thanks for pointing this out. You're completely correct that increasing the capacity makes the queue "not full" and it should notify waiting threads. Unfortunately, as this is an official Eclipse project, I (literally) can't merge a PR from anyone that doesn't have a signed ECA with the Eclipse foundation, which probably isn't worth it for a small change like this. I can get the fix in with this next update. |
fpagliughi
added a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.