Skip to content

Add validation that the remaining length is less than 2^28 #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
63n0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add validation that the remaining length is less than 2^28 #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/paho/mqtt/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3346,6 +3346,8 @@ def _pack_remaining_length(
self, packet: bytearray, remaining_length: int
) -> bytearray:
remaining_bytes = []
if remaining_length > 268_435_455:
raise ValueError("Packet too large")
while True:
byte = remaining_length % 128
remaining_length = remaining_length // 128
Expand All @@ -3356,7 +3358,6 @@ def _pack_remaining_length(
remaining_bytes.append(byte)
packet.append(byte)
if remaining_length == 0:
# FIXME - this doesn't deal with incorrectly large payloads
return packet

def _pack_str16(self, packet: bytearray, data: bytes | str) -> None:
Expand Down