Make documented client re-exports explicit#908
Open
vvezre wants to merge 2 commits into
Open
Conversation
Signed-off-by: 陈伟 <woshei0a0a0a@qq.com>
Contributor
|
This is nice! |
Contributor
|
It's harmless, but @pswsm I disagree. Paho supports Python, and uses mypy itself during development. Supporting every other type checker's behaviour (in 2025 let alone what they all do now), will just add permanent clutter to to the code base and reduce readability, and increase the maintenance burden. @PierreF The 'issue' this fixes, has no reproduction. I'd just close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paho.mqtt.clientre-exports explicit so static type checkers treat them as public APITesting
python -m pytest tests/test_client.py -k documented_public_reexports -qpyrightagainst a minimal reproducer formqtt.CallbackAPIVersionandmqtt.PropertiesCloses #892