Fix old on_subscribe example in callback migration documentation#909
Open
sid3windr wants to merge 1 commit into
Open
Fix old on_subscribe example in callback migration documentation#909sid3windr wants to merge 1 commit into
sid3windr wants to merge 1 commit into
Conversation
PierreF
reviewed
Jun 10, 2026
|
|
||
| # OLD code for MQTTv5 | ||
| def on_disconnect(client, userdata, mid, reason_codes, properties): | ||
| def on_subscribe(client, userdata, mid, granted_qos, rc, properties=None): |
Contributor
There was a problem hiding this comment.
I believe in MQTTv5, the granted_qos was absent (see calling code in v1.6.1).
That's probably why I made a copy/paste mistake, because in MQTTv5 there is no migration for on_subscribe. But I think it still better to explicitly show old code for MQTTv5, even if unchanged for migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a copy/paste mistake in the example of the old code; I am fairly sure what I put instead is correct but feel free to correct me if wrong...