Skip to content

Fix old on_subscribe example in callback migration documentation #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sid3windr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix old on_subscribe example in callback migration documentation #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/migrations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ on_subscribe
# error processing

# OLD code for MQTTv5
def on_disconnect(client, userdata, mid, reason_codes, properties):
def on_subscribe(client, userdata, mid, granted_qos, rc, properties=None):

@PierreF PierreF Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in MQTTv5, the granted_qos was absent (see calling code in v1.6.1).

That's probably why I made a copy/paste mistake, because in MQTTv5 there is no migration for on_subscribe. But I think it still better to explicitly show old code for MQTTv5, even if unchanged for migration.

for sub_result in reason_codes:
if sub_result == 1:
# process QoS == 1
Expand Down