Replace String.valueOf(true) with "true" literal

laeubi · Copilot · laeubi · commit 0116d1e75ff7 · 2026-03-23T09:45:15.000+01:00
String.valueOf(true) is unnecessarily verbose and incurs a method
call. A string literal is clearer and avoids unnecessary overhead.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/UpdateSingletonToSymbolicName.java b/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/correction/UpdateSingletonToSymbolicName.java
@@ -42,7 +42,7 @@ protected void createChange(BundleModel model) {
 				int ind2 = entry.indexOf(':');
 				String invalidDir = entry.substring(ind1 + 1, ind2);
 				((BundleSymbolicNameHeader) header).setDirective(invalidDir, null);
-				((BundleSymbolicNameHeader) header).setDirective(Constants.SINGLETON_DIRECTIVE, String.valueOf(true));
+				((BundleSymbolicNameHeader) header).setDirective(Constants.SINGLETON_DIRECTIVE, "true"); //$NON-NLS-1$
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected void createChange(BundleModel model) {`
`42`	`42`	`int ind2 = entry.indexOf(':');`
`43`	`43`	`String invalidDir = entry.substring(ind1 + 1, ind2);`
`44`	`44`	`((BundleSymbolicNameHeader) header).setDirective(invalidDir, null);`
`45`		`- ((BundleSymbolicNameHeader) header).setDirective(Constants.SINGLETON_DIRECTIVE, String.valueOf(true));`
	`45`	`+ ((BundleSymbolicNameHeader) header).setDirective(Constants.SINGLETON_DIRECTIVE, "true"); //$NON-NLS-1$`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`	`}`