Commit 1ac91ea
committed
Fix PDEFormEditor.dispose() calling super.dispose() first
Common pattern for init/dispose, setup/teardown is that on init, super
is called first and on dispose last.
This is always done this way to allow super class initialize whatever
needed first and subclass work on that, and the dispose should always
perform cleanup in the opposite direction. Otherwise super code might
cleanup things that are still needed for the subclass to properly
cleanup.
Probably related to
#19631 parent 1c6786d commit 1ac91ea
1 file changed
Lines changed: 1 addition & 1 deletion
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
596 | | - | |
597 | 596 | | |
598 | 597 | | |
| 598 | + | |
599 | 599 | | |
600 | 600 | | |
601 | 601 | | |
| |||
0 commit comments