Do not let one erroneous bundle fail the whole IU container

Currently if there is one failing bundle the whole container resolution
fails and throws an ugly error. In fact there is InvalidTargetBundle for
that purpose already and the profile container is even using that.

THis one now constructs a InvalidTargetBundle whenever one bundle fails
to be constructed from its file.

Author: laeubi

ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/target/IUBundleContainer.java

@@ -473,7 +473,8 @@ public synchronized IUBundleContainer update(Set<String> toUpdate, IProgressMoni
 	 * @param artifacts the underlying artifact repo against which the bundles are validated
 	 * @return map of BundleInfo to IResolvedBundle
 	 */
-	private Map<BundleInfo, TargetBundle> generateResolvedBundles(IQueryable<IInstallableUnit> source, IQueryable<IInstallableUnit> metadata, IFileArtifactRepository artifacts) throws CoreException {
+	private Map<BundleInfo, TargetBundle> generateResolvedBundles(IQueryable<IInstallableUnit> source,
+			IQueryable<IInstallableUnit> metadata, IFileArtifactRepository artifacts) {
 		OSGiBundleQuery query = new OSGiBundleQuery();
 		IQueryResult<IInstallableUnit> queryResult = source.query(query, null);
 		Map<BundleInfo, TargetBundle> bundles = new LinkedHashMap<>();
@@ -492,7 +493,8 @@ private Map<BundleInfo, TargetBundle> generateResolvedBundles(IQueryable<IInstal
 		return bundles;
 	}
 
-	private void generateBundle(IInstallableUnit unit, IFileArtifactRepository repo, Map<BundleInfo, TargetBundle> bundles) throws CoreException {
+	private void generateBundle(IInstallableUnit unit, IFileArtifactRepository repo,
+			Map<BundleInfo, TargetBundle> bundles) {
 		Collection<IArtifactKey> artifacts = unit.getArtifacts();
 		for (IArtifactKey artifactKey : artifacts) {
 			File file = null;
@@ -511,8 +513,16 @@ private void generateBundle(IInstallableUnit unit, IFileArtifactRepository repo,
 				}
 			}
 			if (file != null) {
-				TargetBundle bundle = new TargetBundle(file);
-				bundles.put(bundle.getBundleInfo(), bundle);
+				try {
+					TargetBundle bundle = new TargetBundle(file);
+					bundles.put(bundle.getBundleInfo(), bundle);
+				} catch (CoreException e) {
+					BundleInfo info = new BundleInfo(file.toURI());
+					info.setSymbolicName(artifactKey.getId());
+					info.setVersion(artifactKey.getVersion().toString());
+					InvalidTargetBundle invalidTargetBundle = new InvalidTargetBundle(info, e.getStatus());
+					bundles.put(info, invalidTargetBundle);
+				}
 			}
 		}
 	}