Add comprehensive classpath resolution test for transitive forbidden

access rules

Validates that PDE correctly adds transitive dependencies to the JDT
classpath with K_NON_ACCESSIBLE access rules (PR #2218). Asserts exact
access rule structure, marker line numbers, problem IDs, severity, and
message patterns for all 24 expected forbidden reference markers.

Also Tests both forbiddenReference=warning (project A) and
forbiddenReference=error (project Ae, JDT default) compiler settings.

Additionally tests of discouraged access tests for x-internal:=true
packages

Author: laeubi

ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/core/tests/internal/classpath/ClasspathResolutionTest2.java

@@ -15,6 +15,7 @@
 
 import org.eclipse.pde.core.tests.internal.AllPDECoreTests;
 import org.eclipse.pde.core.tests.internal.classpath.ClasspathResolutionTest;
+import org.eclipse.pde.core.tests.internal.classpath.ClasspathResolutionTest2;
 import org.eclipse.pde.core.tests.internal.core.builders.BundleErrorReporterTest;
 import org.eclipse.pde.core.tests.internal.util.PDESchemaHelperTest;
 import org.eclipse.pde.ui.tests.build.properties.AllValidatorTests;
@@ -63,6 +64,7 @@
 	ClasspathContributorTest.class, //
 	DynamicPluginProjectReferencesTest.class, //
 	ClasspathResolutionTest.class, //
+	ClasspathResolutionTest2.class, //
 	BundleErrorReporterTest.class, //
 	AllPDECoreTests.class, //
 	ProjectSmartImportTest.class, //

ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/AllPDETests.java

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
+<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
+<classpathentry kind="src" path="src"/>
+<classpathentry kind="output" path="bin"/>
+</classpath>

ui/org.eclipse.pde.ui.tests/tests/projects/A/.classpath

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+<name>A</name>
+<comment></comment>
+<projects>
+</projects>
+<buildSpec>
+<buildCommand>
+<name>org.eclipse.jdt.core.javabuilder</name>
+<arguments>
+</arguments>
+</buildCommand>
+<buildCommand>
+<name>org.eclipse.pde.ManifestBuilder</name>
+<arguments>
+</arguments>
+</buildCommand>
+<buildCommand>
+<name>org.eclipse.pde.SchemaBuilder</name>
+<arguments>
+</arguments>
+</buildCommand>
+</buildSpec>
+<natures>
+<nature>org.eclipse.pde.PluginNature</nature>
+<nature>org.eclipse.jdt.core.javanature</nature>
+</natures>
+</projectDescription>

ui/org.eclipse.pde.ui.tests/tests/projects/A/.project

@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+encoding/<project>=UTF-8

ui/org.eclipse.pde.ui.tests/tests/projects/A/.settings/org.eclipse.core.resources.prefs

@@ -0,0 +1,6 @@
+eclipse.preferences.version=1
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=21
+org.eclipse.jdt.core.compiler.compliance=21
+org.eclipse.jdt.core.compiler.release=enabled
+org.eclipse.jdt.core.compiler.source=21
+org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning

ui/org.eclipse.pde.ui.tests/tests/projects/A/.settings/org.eclipse.jdt.core.prefs

@@ -0,0 +1,10 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: A
+Bundle-SymbolicName: A
+Bundle-Version: 1.0.0.qualifier
+Export-Package: a.api
+Import-Package: b.api;version="1.0.0",
+ g.api;version="1.0.0"
+Automatic-Module-Name: A
+Bundle-RequiredExecutionEnvironment: JavaSE-21

ui/org.eclipse.pde.ui.tests/tests/projects/A/META-INF/MANIFEST.MF

@@ -0,0 +1,4 @@
+source.. = src/
+output.. = bin/
+bin.includes = META-INF/,\
+               .

ui/org.eclipse.pde.ui.tests/tests/projects/A/build.properties

@@ -0,0 +1,63 @@
+package a.api;
+
+/**
+ * Test class that references types from multiple bundles to exercise OSGi
+ * visibility and JDT access rules.
+ * <p>
+ * Bundle A declares: {@code Import-Package: b.api, g.api}
+ * <p>
+ * With the correct PDE behavior (PR #2218), all bundles in the transitive
+ * dependency closure are present on the compilation classpath:
+ * <ul>
+ * <li><b>Directly imported bundles</b> (B, G): exported packages are
+ * {@code K_ACCESSIBLE}, non-exported packages caught by EXCLUDE_ALL_RULE
+ * ({@code K_NON_ACCESSIBLE})</li>
+ * <li><b>Transitive dependencies</b> (C, D, E, F, H): all-forbidden access
+ * rules (single {@code **&#47;* K_NON_ACCESSIBLE} rule) — compiler can
+ * resolve types but direct usage produces forbidden reference warnings
+ * (configured via {@code forbiddenReference=warning})</li>
+ * </ul>
+ * <p>
+ * At <b>OSGi runtime</b>, only directly imported packages (b.api, g.api)
+ * would be accessible to A's classloader (OSGi Core R8 §3.9.4). The JDT
+ * access rules enforce this visibility at compile time.
+ */
+public class AClass {
+	// ---- Directly imported bundles (K_ACCESSIBLE for exported packages) ----
+
+	// B exports b.api, A imports b.api → K_ACCESSIBLE → no marker
+	public Object objectFromB_allowed = new b.api.MyObject();
+	// B's b.internal is NOT exported → caught by EXCLUDE_ALL → forbidden warning
+	public Object objectFromB_forbidden = new b.internal.MyObject();
+
+	// G exports g.api, A imports g.api → K_ACCESSIBLE → no marker
+	public Object objectFromG_allowed = new g.api.MyObject();
+	// G's g.internal is NOT exported → caught by EXCLUDE_ALL → forbidden warning
+	public Object objectFromG_forbidden = new g.internal.MyObject();
+
+	// ---- Transitive dependencies (all-forbidden access rules) ----
+	// These types CAN be resolved by the compiler (on classpath for type
+	// hierarchy validation), but produce forbidden reference warnings because
+	// their entries have only **/* K_NON_ACCESSIBLE access rules.
+	// At OSGi runtime, A's classloader cannot load any of these types (§3.9.4).
+
+	// C: Required by B (Require-Bundle: C, default visibility:=private §3.13.1)
+	public Object objectFromC_forbidden1 = new c.api.MyObject();
+	public Object objectFromC_forbidden2 = new c.internal.MyObject();
+
+	// D: Package imported by B (Import-Package: d.api) — never re-exports §3.6.4
+	public Object objectFromD_forbidden1 = new d.api.MyObject();
+	public Object objectFromD_forbidden2 = new d.internal.MyObject();
+
+	// E: Optionally required by B (Require-Bundle: E;resolution:=optional §3.7.5)
+	public Object objectFromE_forbidden1 = new e.api.MyObject();
+	public Object objectFromE_forbidden2 = new e.internal.MyObject();
+
+	// F: Optionally imported by B (Import-Package: f.api;resolution:=optional)
+	public Object objectFromF_forbidden1 = new f.api.MyObject();
+	public Object objectFromF_forbidden2 = new f.internal.MyObject();
+
+	// H: Optionally imported by G (Import-Package: h.api;resolution:=optional)
+	public Object objectFromH_forbidden1 = new h.api.MyObject();
+	public Object objectFromH_forbidden2 = new h.internal.MyObject();
+}

ui/org.eclipse.pde.ui.tests/tests/projects/A/src/a/api/AClass.java

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
+<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
+<classpathentry kind="src" path="src"/>
+<classpathentry kind="output" path="bin"/>
+</classpath>