Add reproducer for cyclic bundle dependencies caused by #2218

Author: ptziegler

ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/core/tests/internal/classpath/ClasspathResolutionTest.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2020, 2023 Red Hat Inc. and others.
+ * Copyright (c) 2020, 2026 Red Hat Inc. and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -17,12 +17,19 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.fail;
 
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
 import java.util.function.Predicate;
+import java.util.jar.Attributes;
+import java.util.jar.Manifest;
 
+import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IMarker;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
@@ -49,6 +56,7 @@
 import org.junit.rules.TestRule;
 import org.mockito.Mockito;
 import org.osgi.framework.Bundle;
+import org.osgi.framework.Constants;
 import org.osgi.framework.FrameworkUtil;
 
 public class ClasspathResolutionTest {
@@ -146,6 +154,22 @@ public void testImportSystemPackageDoesntAddExtraBundleJava8_osgiEERequirement()
 		}
 	}
 
+	@Test
+	public void testRequiredPluginsForFragment() throws IOException, CoreException {
+		IProject projectA = ProjectUtils.createPluginProject("A", "1.0.0");
+		IProject projectConsumer = ProjectUtils.createPluginProject("capabilities.consumer", "1.0.0");
+		IProject projectProvider = ProjectUtils.createPluginProject("capabilities.provider", "1.0.0");
+
+		updateManifest(projectConsumer,
+				Map.of(Constants.REQUIRE_CAPABILITY, "some.test.capability", Constants.FRAGMENT_HOST, "A"));
+		updateManifest(projectProvider,
+				Map.of(Constants.PROVIDE_CAPABILITY, "some.test.capability", Constants.REQUIRE_BUNDLE, "A"));
+
+		assertThat(getRequiredPluginContainerEntries(projectA)).isEmpty();
+		assertThat(getRequiredPluginContainerEntries(projectConsumer)).containsExactlyInAnyOrder("A1_0_0");
+		assertThat(getRequiredPluginContainerEntries(projectProvider)).containsExactlyInAnyOrder("A1_0_0");
+	}
+
 	// --- utilitiy methods ---
 
 	private List<String> getRequiredPluginContainerEntries(IProject project) throws CoreException {
@@ -186,4 +210,22 @@ private AutoCloseable mockExtraExtraJRESystemPackages(String eeId, List<String>
 			MinimalState.reloadSystemPackagesIntoState();
 		};
 	}
+
+	private void updateManifest(IProject project, Map<String, String> headers) throws IOException, CoreException {
+		IFile manifestFile = project.getFile("META-INF/MANIFEST.MF");
+
+		Manifest manifest;
+		try (InputStream is = manifestFile.getContents()) {
+			manifest = new Manifest(is);
+		}
+
+		Attributes attributes = new Attributes();
+		headers.forEach(attributes::putValue);
+		manifest.getMainAttributes().putAll(attributes);
+
+		try (ByteArrayOutputStream os = new ByteArrayOutputStream()) {
+			manifest.write(os);
+			manifestFile.setContents(os.toByteArray(), IResource.FORCE, null);
+		}
+	}
 }