Commit 84b6d63
committed
Make spyPart shortcut attribute optional
The shortcut attribute on the org.eclipse.pde.spy.core.spyPart extension
point is not declared as required in its schema, but SpyProcessor would
NPE when a contribution omitted it (keySequence.equals in
bindSpyKeyBinding). Skip key-binding registration when no shortcut is
provided so a spy can opt into discoverability via the spy stack toolbar
without claiming a global keystroke.1 parent 5c5792d commit 84b6d63
2 files changed
Lines changed: 5 additions & 2 deletions
File tree
- ui/org.eclipse.pde.spy.core
- src/org/eclipse/pde/spy/core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
85 | 87 | | |
86 | 88 | | |
87 | 89 | | |
| |||
0 commit comments