-configuration param creates paths with %20 instead of whitespaces

[jsc57x]

If you run an Eclipse Application from a Launch Config which contains a configuration area which contains whitespaces, the paramter -configuration in the command line is URI encoded and therefore contains %20 instead of the whitespaces.
The link in the ui points to the correct path without whitespaces and other paths like data or debug do not contain whitespaces.
This error results in different locations for configuration files (e.g. the config.ini is created in the path without whitespaces but the path to the osgi cache contains %20).

The change seems to be recently made in e62be0b

[merks]

Indeed I already fixed one such problem just last week:

#1709

Could you please be more explicit exactly where you see problem so that I can try to help address them. A a list with screen-capture examples would be very helpful. Anything we can get fixed today or tomorrow with be in 2025-06 M1 next...

FYI, for the Platform SDK setup I generated a launch configuration named "Runtime Workspace" so all problems should be easily reproducible the the developers.

[jsc57x]

I think the problem is shown in the screenshot of #1708 (comment) but in the line above the marked one (-configuration)

[merks]

I think the problem is shown in the screenshot of #1708 (comment) but in the line above the marked one (-configuration)

I've fixed that problem so if that's the only problem then we're done.

Can you try out this to see if all the problems are fixed?

https://download.eclipse.org/eclipse/downloads/drops4/I20250331-1800/

[jsc57x]

I'll try it tomorrow

[merks]

That would be great! Thanks.

[jsc57x]

Unfortunately the problem isn't solved.

[merks]

That is the way it is supposed to look.

It is supposed to be a well-formed URI where a ' 'must be encoded as '%20'.

If that causes a problem, that problem (because something doesn't properly decode the URI) that should be fixed, but you've not described such a problem and I've already fixed such a problem. There may be more such problems, but I don't know of any...

[jsc57x]

If I run the launch configuration the folder path for the configuration area is created with %20. I suppose that this is a problem with the runner?

[merks]

Please, please, screen captures and concrete paths.

When I search the host workspace ws and the launched workspace runtime-workspace for files containing % I don't see anything offensive:

merks@CORE MINGW64 /d/Users/merks/platform-sdk-4.36
$find runtime-workspace ws -name "*%*"
ws/.metadata/.plugins/org.eclipse.pde.core/.p2/org.eclipse.equinox.p2.engine/profileRegistry/TARGET_DEFINITION%58;resource%58;%47;org.eclipse.platform.releng.prereqs.sdk%47;eclipse-sdk-prereqs.target.profile

merks@CORE MINGW64 /d/Users/merks/platform-sdk-4.36

Similarly when I search for files with ' ' I see what I expect:

merks@CORE MINGW64 /d/Users/merks/platform-sdk-4.36
$find runtime-workspace ws -name "* *" | grep Runtime
ws/.metadata/.plugins/org.eclipse.debug.core/.launches/Runtime Workspace Many Projects.launch
ws/.metadata/.plugins/org.eclipse.debug.core/.launches/Runtime Workspace.launch
ws/.metadata/.plugins/org.eclipse.pde.core/Runtime Workspace
ws/.metadata/.plugins/org.eclipse.pde.core/Runtime Workspace Many Projects

merks@CORE MINGW64 /d/Users/merks/platform-sdk-4.36

[merks]

If I remember correctly if you are reuse an existing workspace that was created with the bug present then simply updating doesn't fix the problem. If you create a new launch configuration (change anything in the name) new things are created that should work correctly.

[jsc57x]

I currently don't have a minimal reproducable example.
The problem does not occur if I simply run a new eclipse application launch configuration.
I've downloaded the nightly Eclipse, installed a few needed plugins (M2E and e(fx)clipse) created a new workspace (with spaces). Created a new launch config, selected our product and executed it.
In this workspace even a new launch config creates the path to the configuration area with %20 instead of spaces. As it seems you are using Linux, I'm using Windows 11 on my site.
It might be helpful which data is stored in the plugin path:

If I am not mistaken, the folders contain jars which are contained in an OSGi-Bundle as nested jars

[jsc57x]

If you're interested in specific screenshots i might be able to provide some but I don't know what is interesting at this point.

[merks]

Even if I put a space in the name of the workspace itself, that works okay:

$find runtime-workspace ws runtime\ workspace\ with\ space/ -name "*%*"
ws/.metadata/.plugins/org.eclipse.pde.core/.p2/org.eclipse.equinox.p2.engine/profileRegistry/TARGET_DEFINITION%58;resource%58;%47;org.eclipse.platform.releng.prereqs.sdk%47;eclipse-sdk-prereqs.target.profile

I just don't see anything further to fix...

[HannesWell]

It is supposed to be a well-formed URI where a ' 'must be encoded as '%20'.

If that causes a problem, that problem (because something doesn't properly decode the URI) that should be fixed,

I fully second that.

There may be more such problems, but I don't know of any...

I think there are many places that need a fix as discussed in eclipse-platform/eclipse.platform#35. But hopefully most will be stamped out in the not too distant future.

[jsc57x]

I'm not sure what code copies the JARs to the folder with %20. I've started debugging and at least the equinox launcher's Main class checks the directory. This might be an incompatibility using the newest Eclipse version as an IDE and running an older Application based on RCP. We are updating our dependencies and I will check again.
This was the commit which changed the behaviour: eclipse-equinox/equinox@78e9896
As this is not a bug in Eclipse PDE I will close this ticket