Require-Capability: eclipse.swt;filter:="(image.format=svg)" leads to warning message during startup via PDE launch

[vogella]

Adding Require-Capability: eclipse.swt;filter:="(image.format=svg)" to the MANIFEST.MF leads to a runtime error even if the new SWT fragment is present.

To replicate use Eclipse 4 RCP template, add Require-Capability: eclipse.swt;filter:="(image.format=svg)" to the manifest and start via the generated product.

[laeubi]

leads to a runtime error even if the new SWT fragment is present.

What kind of error? If it really happens at runtime it is either a wrong configuration or an Equinox issue ...

[vogella]

You see a pop-up that this Capability is not found.

[laeubi]

You see a pop-up that this Capability is not found.

A popup is not a runtime error, so if you actually ignore this and run the product does it work to load SVGs?

[iloveeclipse]

Could it be related to eclipse-platform/eclipse.platform.swt#2049 ?

[vogella]

You see a pop-up that this Capability is not found.

A popup is not a runtime error, so if you actually ignore this and run the product does it work to load SVGs?

Yes

[vogella]

You see a pop-up that this Capability is not found.

A popup is not a runtime error, so if you actually ignore this and run the product does it work to load SVGs?

Yes (I never said runtime error)

[laeubi]

Yes

Thanks for confirmation, then it seems that something in the validation is missing that here, there are some cases in the past where we see those false positive warnings but the actual execution (aka runtime) is working well.

(I never said runtime error)

Just for the record:

[vogella]

• Import of the dark theme and update of it@import url("platform:/plugin/org.eclipse.ui.themes/css/e4-dark.css");

[HannesWell]

You see a pop-up that this Capability is not found.

A popup is not a runtime error, so if you actually ignore this and run the product does it work to load SVGs?

Yes one sees the validation pop-up:

To replicate this, one just has to make sure that the org.eclipse.e4.rcp feature does not include the fragment org.eclipse.swt.svg.

But when inspecting the generated org.eclipse.equinox.simpleconfigurator/bundles.info, the com.github.weisj.jsvg is not listed and when I continue the launch I get corresponding resolution errors at runtime. So the validation is in fact right and I think the automatic inclusion of dependencies is missing something around the handling of fragments in:

eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/DependencyManager.java

Lines 199 to 213 in 0649a16

	List<BundleWire> requiredWires = wiring.getRequiredWires(null);
	for (BundleWire wire : requiredWires) {
	BundleRevision declaringBundle = wire.getRequirement().getRevision();
	if (declaringBundle != bundle && !closure.contains(declaringBundle)) {
	// Requirement is declared by an attached fragment, which is
	// not included into the closure.
	continue;
	}
	BundleRevision provider = wire.getCapability().getRevision();
	// Use revision of required capability to support the case if
	// fragments contribute new packages to their host's API.
	if (provider instanceof BundleDescription requiredBundle && (includeOptional || !isOptional(wire.getRequirement()))) {
	addNewRequiredBundle(requiredBundle, closure, pending);
	}
	}

But when looking at this, I cannot see an immediate cause. I'll look into this ASAP.