Inconsitency between Tycho and PDE leads to compilation errors in IDE

[iloveeclipse]

Since today I see two compilation errors in the IDE, caused by the new cleanups enabled.

Description	Resource	Path	Location	Type
The project was not built since its build path is incomplete. Cannot find the class file for org.eclipse.core.databinding.property.value.IValueProperty. Fix the build path then try building this project	org.eclipse.e4.tools		Unknown	Java Problem
The type org.eclipse.core.databinding.property.value.IValueProperty cannot be resolved. It is indirectly referenced from required type org.eclipse.jface.databinding.swt.IWidgetValueProperty	AbstractNewClassPage.java	/org.eclipse.e4.tools/src/org/eclipse/e4/internal/tools/wizards/classes	line 253	Java Problem
The method make(Class<ResourceService.ResourcePool>, IEclipseContext) from the type ContextInjectionFactory refers to the missing type InjectionException	ResourcePoolFactory.java	/org.eclipse.e4.tools.services/src/org/eclipse/e4/tools/services/impl	line 25	Java Problem

Commits caused regression

• 1e53ff5
• 717881c

We should stop applying these cleanups automatically until the issue is understood & fix the manifests to avoid errors.

[iloveeclipse]

The fix for IDE is #2196.

I haven't looked what else was affected by these cleanups & where it is broken in general.

[laeubi]

We should stop applying these cleanups automatically until the issue is understood & fix the manifests to avoid errors.

They are not applied automatically, the maven build succeed so it seems a bug in PDE, I'll try to take a look...

[shubhamagore]

Hi @iloveeclipse , I’ve looked into this and it seems to be caused by missing Eclipse Data Binding and DI dependencies, leading to an incomplete build path.

Tentative fix:

• Ensure required bundles are available in the target platform:
  org.eclipse.core.databinding
  org.eclipse.core.databinding.property
  org.eclipse.jface.databinding
  org.eclipse.e4.core.di
• Refresh/resolve target platform and clean rebuild.

If okay, please assign this issue to me and I’ll work on fixing the dependency setup.

[iloveeclipse]

Tentative fix:

I have almost all SDK bundles in my workspace (including those above) & I did clean build several times.
I'm using latest SDK build I20260119-1800

[vogella]

See #2115

[laeubi]

I have now analyzed this and the problematic code part is

@Override
public Object compute(IEclipseContext context, String contextKey) {
	return ContextInjectionFactory.make(ResourcePool.class, context);
}

The ContextInjectionFactory.make throws a InjectionException and this is part of org.eclipse.e4.core.di. While as a runtime exception it is never used (no try/catch or similar) or created (e.g. new InjectionException) the code is free of any reference of this class. Still at compilation the compiler needs to know the type to determine what type of exception this is.