Skip to content

API Tools and sealed classes in the Skia plugin #2394

Description

@DenisUngemach

Hello, I wanted to extend SWT with a Skia Plugin, which requires some modifications to the SWT code as well.

PR: eclipse-platform/eclipse.platform.swt#3231

One of these modifications is that the GC class receives the sealed modifier, with GCExtension extending the GC.

To prevent API tools errors, I had to set some filter values. However, these are declared as unused in the Skia Plugin PR: https://github.com/eclipse-platform/eclipse.platform.swt/pull/3231/checks?check_run_id=83400991229

However, when I remove the specified filters from the code, other errors appear. See this PR: swt-initiative31/skija-canvas#100

But if I remove the sealed modifier and make GCExtension a simple extension of GC (where GC is neither sealed nor final), the build works without the specified filters:

swt-initiative31/skija-canvas#101

This makes me wonder: I would expect that the API tools do not distinguish between extending sealed classes and normal classes. For attribute visibility, there should be no difference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions