Remove preference listener if manager is shut down or project is deleted#1707
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Mar 27, 2025
Conversation
The PreferenceChangeListener that is added when a project is created/opened or when the plugin is started needs to be removed when the project is deleted, in order to make it eligible for garbage collection.
Contributor
Author
|
The memory leak that is caused by this as seen in eclipse-tycho/tycho#4906
|
Contributor
Author
|
I'm fairly certain the new Maven warnings are unrelated... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PreferenceChangeListener that is added when a project is created/opened or when the plugin is started needs to be removed when the project is deleted, in order to make it eligible for garbage collection.