Remove listeners in MinimalState if bundle is stopped#1712
Merged
HannesWell merged 1 commit intoeclipse-pde:masterfrom Apr 4, 2025
Merged
Conversation
Contributor
Author
|
One of the other memory leaks in PDE I've noticed: |
HannesWell
reviewed
Apr 2, 2025
This change adapts the listeners that have been added with 24e9bb5 so that they are removed again, once the bundle is shut down and thus makes the classloader eligible for garbage collection.
HannesWell
force-pushed
the
cleanup-listeners-in-minimal-state
branch
from
5c89aec to
12beb8a
Compare
HannesWell
approved these changes
Apr 4, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
I have now applied the requested changes to this PR.
Thank you for this contribution!
Contributor
Author
|
Whoops. Apologies, I didn't see you comment. Thanks for applying the the changes and merging everything. |
Member
|
This caused regression, please check #1714 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adapts the listeners that have been added with 24e9bb5 so that they are removed again, once the bundle is shut down and thus makes the classloader eligible for garbage collection.