Fix Implicit narrowing conversion in compound assignment#1717
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Apr 8, 2025
Merged
Conversation
Test Results 285 files 285 suites 51m 1s ⏱️ Results for commit 468e8b7. ♻️ This comment has been updated with latest results. |
Currently we add a long to an int this can result in information loss and numeric errors such as overflows. As we only skip an integer amount of bytes the result can also only be an int of bytes skipped, adding an explicit cast makes the security scanner happy here.
laeubi
force-pushed
the
Implicit_narrowing_conversion_in_compound_assignment
branch
from
6e9bafb to
468e8b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we add a long to an int this can result in information loss and numeric errors such as overflows.
As we only skip an integer amount of bytes the result can also only be an int of bytes skipped, adding an explicit cast makes the security scanner happy here.