Reduce re-computation of plugins included in Eclipse/OSGi launches#1724
Merged
HannesWell merged 1 commit intoeclipse-pde:masterfrom May 1, 2025
Merged
Conversation
Test Results 285 files 285 suites 50m 54s ⏱️ Results for commit 0418886. ♻️ This comment has been updated with latest results. |
HannesWell
commented
Apr 21, 2025
HannesWell
force-pushed
the
reduce-bundleSet-recomputation
branch
from
6e61a52 to
00ec25c
Compare
HannesWell
commented
Apr 21, 2025
HannesWell
force-pushed
the
reduce-bundleSet-recomputation
branch
from
00ec25c to
fa58eb3
Compare
Contributor
|
This definitely does not help solve the problem I have with EMF's workspace. |
Member
Author
|
Yes. This is just intended as preceding clean-up/optimization so that the set of included plugins is only computed once per launch. The actual solution should be #1725. |
HannesWell
force-pushed
the
reduce-bundleSet-recomputation
branch
4 times, most recently
from
dc7ea56 to
e2b0a03
Compare
This ensures consistency and reduces calls of DependencyManager.findRequirementsClosure().
HannesWell
force-pushed
the
reduce-bundleSet-recomputation
branch
from
e2b0a03 to
0418886
Compare
basilevs
added a commit
to eclipse-rcptt/org.eclipse.rcptt
that referenced
this pull request
May 4, 2025
Signature of VMHelper.getVMInstall() has changed in eclipse-pde/eclipse.pde#1724
basilevs
added a commit
to eclipse-rcptt/org.eclipse.rcptt
that referenced
this pull request
May 4, 2025
Signature of VMHelper.getVMInstall() has changed in eclipse-pde/eclipse.pde#1724
basilevs
added a commit
to eclipse-rcptt/org.eclipse.rcptt
that referenced
this pull request
May 4, 2025
Signature of VMHelper.getVMInstall() has changed in eclipse-pde/eclipse.pde#1724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures consistency and reduces calls of
DependencyManager.findRequirementsClosure().