Add SVGs to org.eclipse.pde.spy bundles

[Michael5601]

This PR adds SVGs for all icons in the bundles org.eclipse.pde.spy.bundle, org.eclipse.pde.spy.context, org.eclipse.pde.spy.css and org.eclipse.pde.spy.event except for the following as these are not available as SVG yet:

org.eclipse.pde.spy.context/splash.svg (is not used in this bundle)

The bundle org.eclipse.pde.spy.core uses only one icon spyicon.png in the file fragment.e4xmi which is not available as SVG yet.

The bundle org.eclipse.pde.spy.model uses only one icon application_lightning.png which is also not available as SVG yet.

Almost all icons in bundle org.eclipse.pde.spy.preferences are named like enabled icons but are disabled looking. I ignored this bundle as no similar SVGs are available.

See also this PR for more information.

[akurtakov]

Has your ECA expired?

[Michael5601]

Has your ECA expired?

I already saw this and tried to sign in but the site is down and then I thought this is due to the current problems at eclipse foundation:

The weird part is that the ECA is valid for other projects like JDT.

[iloveeclipse]

Has your ECA expired?

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5921

[akurtakov]

Short version - nothing works now

[merks]

Yes, license checking and ECA seem broken.

[iloveeclipse]

See https://www.eclipsestatus.io/maintenance/549775

[github-actions]

Test Results

   285 files  ±0     285 suites  ±0   58m 40s ⏱️ + 10m 40s
 3 608 tests ±0   3 532 ✅ ±0   76 💤 ±0  0 ❌ ±0 
11 016 runs  ±0  10 785 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit cc330dd. ± Comparison against base commit 63f5b3a.

♻️ This comment has been updated with latest results.

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From fe84e687e6e4b4391023f449d2a0162ae38ab76b Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Mon, 28 Apr 2025 18:00:43 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
index 0bb0a4ec41..b99cefd276 100644
--- a/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.spy.event;singleton:=true
-Bundle-Version: 1.2.0.qualifier
+Bundle-Version: 1.2.100.qualifier
 Bundle-Vendor: Eclipse Foundation
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[HannesWell]

Thank you @Michael5601 for for providing these SVGs they look all good.

Do you plan to contribute the missing SVGs later?
Looking at the E4 Spies menu via Window -> Spies one can really see the difference:

One can also see that the icons in the top left are poorly scaled up, even with SVGs. I assume that happens on the raw image. But I first have to find out where exactly.

Btw. I noticed that the contributed SVG files either contain file-system links or contain base-encoded PNGs. Is this correct and relevant?

[HeikoKlare]

Btw. I noticed that the contributed SVG files either contain file-system links or contain base-encoded PNGs. Is this correct and relevant?

This is only the export path that may be used, e.g., by SVG tools to export to (or propose as export path). I agree that it's not that nice to have that path in the SVGs, but it's the case for many of them (also in Platform UI) and since it does no harm I don't see a need to invest effort into changing that.

[HannesWell]

Yes, I assumed that that's the case. Thanks.
Then lets add this as it is now and if one is interested to clean that up later. I hope that a simple search and replace/remove would do the job for all SVGs in the repo.

[Michael5601]

Thank you @Michael5601 for for providing these SVGs they look all good.

Do you plan to contribute the missing SVGs later?

Thanks for the review :) Yes I plan to contribute the missing SVGs.