Add SVGs to org.eclipse.pde.ui bundles#1734
Add SVGs to org.eclipse.pde.ui bundles#1734HannesWell merged 1 commit intoeclipse-pde:masterfrom Michael5601:org.eclipse.pde.ui.SVGs
Conversation
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
I did not change occurences of PNGs in classes like ExtensionSection, AboutSection or WindowImagesSection in org.eclipse.pde.ui as this would change business functionality and I don't know the side effects of it or if they are even connected to viewing images in the IDE.
I think we need to go other this in a separate step and see whether we need to allow SVGs in addition to PNGs and GIFs, like we need to do for the Plug-in Image Browser (#1722).
These images might come from https://github.com/bndtools/bnd, @laeubi can you tell?
I'll have a look at this. If possible, I would prefer to change this now. |
This commit adds SVGs for all icons in the bundle `org.eclipse.pde.ui` and `org.eclipse.pde.ui.templates` except for the following as these are not available as SVG yet: org.eclipse.pde.ui/bndtools/bndrun.svg org.eclipse.pde.ui/bndtools/bundle.svg org.eclipse.pde.ui/bndtools/database.svg org.eclipse.pde.ui/elcl16/cleanmanifest.svg org.eclipse.pde.ui/etool16/eclipse.svg org.eclipse.pde.ui/obj16/eclipse.svg org.eclipse.pde.ui.templates/etool16/e4.svg I did not change occurrences of PNGs in classes like `ExtensionSection`, `AboutSection` or `WindowImagesSection` in `org.eclipse.pde.ui` as this would change business functionality and I don't know the side effects of it or if they are even connected to viewing images in the IDE. I did not change any references to `sample.png` or `eclipseXX.png` in `org.eclipse.pde.ui.templates` as these are references to other bundles or maybe placeholders.
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
This change looks good. Thanks.
I did not change occurences of PNGs in classes like
ExtensionSection,AboutSectionorWindowImagesSectioninorg.eclipse.pde.uias this would change business functionality and I don't know the side effects of it or if they are even connected to viewing images in the IDE.
I looked into it and made the possible changes in
|
This PR most likely introduces regression, see #1766 |
4 participants
This PR adds SVGs for all icons in the bundle
org.eclipse.pde.uiandorg.eclipse.pde.ui.templatesexcept for the following as these are not available as SVG yet:org.eclipse.pde.ui/bndtools/bndrun.svg
org.eclipse.pde.ui/bndtools/bundle.svg
org.eclipse.pde.ui/bndtools/database.svg
org.eclipse.pde.ui/elcl16/cleanmanifest.svg
org.eclipse.pde.ui/etool16/eclipse.svg
org.eclipse.pde.ui/obj16/eclipse.svg
org.eclipse.pde.ui.templates/etool16/e4.svg
I did not change occurences of PNGs in classes like
ExtensionSection,AboutSectionorWindowImagesSectioninorg.eclipse.pde.uias this would change business functionality and I don't know the side effects of it or if they are even connected to viewing images in the IDE.I did not change any references to
sample.pngoreclipseXX.pnginorg.eclipse.pde.ui.templatesas these are references to other bundles or maybe placeholders.