Replace pre-generated disabled icon with on-the-fly generated ones#1742
Merged
HannesWell merged 1 commit intoeclipse-pde:masterfrom Apr 29, 2025
Merged
Replace pre-generated disabled icon with on-the-fly generated ones#1742HannesWell merged 1 commit intoeclipse-pde:masterfrom
HannesWell merged 1 commit intoeclipse-pde:masterfrom
Conversation
SWT's algorithm to calculate disabled icons on the fly has been enhanced to produce results that are equal to the existing, pre-generated disabled icons being used. This makes the usage of pre-generated disabled icons obsolete. This is particularly important for the introduction of SVG icons, as the quality of on-the-fly generated disabled icons based on the original SVGs is better for arbitrary zooms than the scaled up or scaled downs versions of the PNG-based disabled icons. This change removes all explicit specifications of disabled icons unless it's a usage of one of Platform's shared images.
HeikoKlare
force-pushed
the
disabled-remove
branch
from
ad7da81 to
b71bc85
Compare
HannesWell
approved these changes
Apr 29, 2025
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Looks good.
Thank you for this clean-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWT's algorithm to calculate disabled icons on the fly has been enhanced to produce results that are equal to the existing, pre-generated disabled icons being used. This makes the usage of pre-generated disabled icons obsolete. This is particularly important for the introduction of SVG icons, as the quality of on-the-fly generated disabled icons based on the original SVGs is better for arbitrary zooms than the scaled up or scaled downs versions of the PNG-based disabled icons.
This change removes all explicit specifications of disabled icons unless it's a usage of one of Platform's shared images.