Skip to content

Replace pre-generated disabled icon with on-the-fly generated ones #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HannesWell merged 1 commit into from
Apr 29, 2025
Merged

Replace pre-generated disabled icon with on-the-fly generated ones #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...s/org.eclipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/ApiUIPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ public class ApiUIPlugin extends AbstractUIPlugin {
*/
private static final String ICONS_PATH = "$nl$/icons/full/"; //$NON-NLS-1$

private static final String DLCL = ICONS_PATH + "dlcl16/"; //basic colors - size 16x16 disabled//$NON-NLS-1$

private static final String ELCL = ICONS_PATH + "elcl16/"; //basic colors - size 16x16 //$NON-NLS-1$

/**
Expand Down Expand Up @@ -300,17 +298,11 @@ protected void initializeImageRegistry(ImageRegistry reg) {
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_HELP_PAGE, ELCL + "help.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_COMPARE_APIS, ELCL + "compare_apis.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_CONFIG_SEV, ELCL + "configure_problem_severity.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_COMPARE_APIS_DISABLED, DLCL + "compare_apis.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_EXPORT, ELCL + "export.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_NEXT_NAV, ELCL + "next_nav.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_PREV_NAV, ELCL + "prev_nav.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_EXPANDALL, ELCL + "expandall.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_ELCL_TEXT_EDIT, ELCL + "text_edit.png"); //$NON-NLS-1$
// disabled images
declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_EXPORT, DLCL + "export.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_NEXT_NAV, DLCL + "next_nav.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_PREV_NAV, DLCL + "prev_nav.png"); //$NON-NLS-1$
declareRegistryImage(reg, IApiToolsConstants.IMG_DLCL_EXPANDALL, DLCL + "expandall.png"); //$NON-NLS-1$
}

void showAPIToolingView() {
Expand Down
20 changes: 0 additions & 20 deletions ...clipse.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/IApiToolsConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ public interface IApiToolsConstants {
public static final String IMG_ELCL_COMPARE_APIS = "IMG_ELCL_COMPARE_APIS"; //$NON-NLS-1$

public static final String IMG_ELCL_CONFIG_SEV = "IMG_ELCL_CONFIG_SEV"; //$NON-NLS-1$
/**
* Key for a compare api disabled image
*/
public static final String IMG_ELCL_COMPARE_APIS_DISABLED = "IMG_ELCL_COMPARE_APIS_DISABLED"; //$NON-NLS-1$
/**
* Key for filter resolution image
*/
Expand Down Expand Up @@ -152,10 +148,6 @@ public interface IApiToolsConstants {
* Key for enabled export image
*/
public static final String IMG_ELCL_EXPORT = "IMG_ELCL_EXPORT"; //$NON-NLS-1$
/**
* Key for disabled export image
*/
public static final String IMG_DLCL_EXPORT = "IMG_DLCL_EXPORT"; //$NON-NLS-1$
/**
* Key for enabled next navigation image
*/
Expand All @@ -164,20 +156,8 @@ public interface IApiToolsConstants {
* Key for enabled previous navigation image
*/
public static final String IMG_ELCL_PREV_NAV = "IMG_ELCL_PREV_NAV"; //$NON-NLS-1$
/**
* Key for disabled next navigation image
*/
public static final String IMG_DLCL_NEXT_NAV = "IMG_DLCL_NEXT_NAV"; //$NON-NLS-1$
/**
* Key for disabled previous navigation image
*/
public static final String IMG_DLCL_PREV_NAV = "IMG_DLCL_PREV_NAV"; //$NON-NLS-1$
/**
* Key for enabled expand all image
*/
public static final String IMG_ELCL_EXPANDALL = "IMG_ELCL_EXPANDALL"; //$NON-NLS-1$
/**
* Key for disabled expand all image
*/
public static final String IMG_DLCL_EXPANDALL = "IMG_DLCL_EXPANDALL"; //$NON-NLS-1$
}
2 changes: 0 additions & 2 deletions ...e.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExpandAllAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ public ExpandAllAction(TreeViewer viewer) {
setToolTipText(ActionMessages.ExpandAllAction_tooltip);
ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPANDALL);
setImageDescriptor(enabledImageDescriptor);
ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPANDALL);
setDisabledImageDescriptor(disabledImageDescriptor);
fViewer = viewer;
}

Expand Down
2 changes: 0 additions & 2 deletions ...e.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/ExportSessionAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ public ExportSessionAction(APIToolingView view) {
setToolTipText(ActionMessages.ExportSessionAction_tooltip);
ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_EXPORT);
setImageDescriptor(enabledImageDescriptor);
ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_EXPORT);
setDisabledImageDescriptor(disabledImageDescriptor);
setEnabled(false);
this.view = view;
}
Expand Down
4 changes: 0 additions & 4 deletions ...se.pde.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/NavigateAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ public NavigateAction(APIToolingView view, boolean next) {
setToolTipText(ActionMessages.NextAction_tooltip);
ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_NEXT_NAV);
setImageDescriptor(enabledImageDescriptor);
ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_NEXT_NAV);
setDisabledImageDescriptor(disabledImageDescriptor);
setActionDefinitionId(ActionFactory.NEXT.getCommandId());
if (bars != null) {
bars.setGlobalActionHandler(ActionFactory.NEXT.getId(), this);
Expand All @@ -52,8 +50,6 @@ public NavigateAction(APIToolingView view, boolean next) {
setToolTipText(ActionMessages.PreviousAction_tooltip);
ImageDescriptor enabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_PREV_NAV);
setImageDescriptor(enabledImageDescriptor);
ImageDescriptor disabledImageDescriptor = ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_DLCL_PREV_NAV);
setDisabledImageDescriptor(disabledImageDescriptor);
setActionDefinitionId(ActionFactory.PREVIOUS.getCommandId());
if (bars != null) {
bars.setGlobalActionHandler(ActionFactory.PREVIOUS.getId(), this);
Expand Down
1 change: 0 additions & 1 deletion ...e.api.tools.ui/src/org/eclipse/pde/api/tools/ui/internal/actions/SelectSessionAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public SelectSessionAction() {
setText(ActionMessages.SelectSessionAction_label);
setToolTipText(ActionMessages.SelectSessionAction_tooltip);
setImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS));
setDisabledImageDescriptor(ApiUIPlugin.getImageDescriptor(IApiToolsConstants.IMG_ELCL_COMPARE_APIS_DISABLED));
setMenuCreator(this);
setEnabled(false);
}
Expand Down
9 changes: 0 additions & 9 deletions ui/org.eclipse.pde.bnd.ui/src/org/eclipse/pde/bnd/ui/views/repository/RepositoriesView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@ private void setPrefrences(BndPreferences preferences) {
offlineAction.setChecked(false);
offlineAction.setToolTipText("Go Offline");
offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));
offlineAction.setEnabled(false);
return;
}
Expand All @@ -526,12 +525,10 @@ protected void updateOfflineAction(boolean offline) {
offlineAction.setChecked(true);
offlineAction.setToolTipText("Go Online");
offlineAction.setImageDescriptor(Resources.getImageDescriptor("disconnect.png"));
offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("disconnect_d.png"));
} else {
offlineAction.setChecked(false);
offlineAction.setToolTipText("Go Offline");
offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));
}
offlineAction.setEnabled(true);
}
Expand Down Expand Up @@ -622,7 +619,6 @@ public void run() {
collapseAllAction.setText("Collapse All");
collapseAllAction.setToolTipText("Collapse All");
collapseAllAction.setImageDescriptor(Resources.getImageDescriptor("collapseall.png"));
collapseAllAction.setDisabledImageDescriptor(Resources.getImageDescriptor("collapseall_d.png"));

refreshAction = new Action() {
@Override
Expand Down Expand Up @@ -658,7 +654,6 @@ public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException {
refreshAction.setText("Refresh");
refreshAction.setToolTipText("Refresh Repositories Tree");
refreshAction.setImageDescriptor(Resources.getImageDescriptor("arrow_refresh.png"));
refreshAction.setDisabledImageDescriptor(Resources.getImageDescriptor("arrow_refresh_d.png"));

addBundlesAction = new Action() {
@Override
Expand All @@ -681,7 +676,6 @@ public void run() {
addBundlesAction.setText("Add");
addBundlesAction.setToolTipText("Add Bundles to Repository");
addBundlesAction.setImageDescriptor(Resources.getImageDescriptor("add_obj.png"));
addBundlesAction.setDisabledImageDescriptor(Resources.getImageDescriptor("add_obj_d.png"));

advancedSearchAction = new Action("Advanced Search", IAction.AS_CHECK_BOX) {
@Override
Expand Down Expand Up @@ -728,7 +722,6 @@ public void run() {
advancedSearchAction.setText("Advanced Search");
advancedSearchAction.setToolTipText("Toggle Advanced Search");
advancedSearchAction.setImageDescriptor(Resources.getImageDescriptor("search.png"));
advancedSearchAction.setDisabledImageDescriptor(Resources.getImageDescriptor("search_d.png"));

downloadAction = new Action() {
@Override
Expand Down Expand Up @@ -781,7 +774,6 @@ private <T> List<T> selectionByType(IStructuredSelection selection, Class<T> typ
downloadAction.setEnabled(false);
downloadAction.setText("Download Repository Content");
downloadAction.setImageDescriptor(Resources.getImageDescriptor("download.png"));
downloadAction.setDisabledImageDescriptor(Resources.getImageDescriptor("download_d.png"));

offlineAction = new Action("Online/Offline Mode", IAction.AS_CHECK_BOX) {
@Override
Expand All @@ -795,7 +787,6 @@ public void run() {
offlineAction.setEnabled(false);
offlineAction.setToolTipText("Go Offline");
offlineAction.setImageDescriptor(Resources.getImageDescriptor("connect.png"));
offlineAction.setDisabledImageDescriptor(Resources.getImageDescriptor("connect_d.png"));

viewer.addSelectionChangedListener(event -> {
IStructuredSelection selection = (IStructuredSelection) event.getSelection();
Expand Down
2 changes: 0 additions & 2 deletions ui/org.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/PDERuntimePluginImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ public class PDERuntimePluginImages {
public final static String ICONS_PATH = "icons/"; //$NON-NLS-1$

private static final String PATH_OBJ = ICONS_PATH + "obj16/"; //$NON-NLS-1$
private static final String PATH_DCL = ICONS_PATH + "dlcl16/"; //$NON-NLS-1$
private static final String PATH_LCL = ICONS_PATH + "elcl16/"; //$NON-NLS-1$
private static final String PATH_OVR = ICONS_PATH + "ovr16/"; //$NON-NLS-1$

Expand Down Expand Up @@ -57,7 +56,6 @@ public class PDERuntimePluginImages {
public static final ImageDescriptor COPY_QNAME = create(PATH_LCL, IMG_COPY_QNAME);
public static final ImageDescriptor UP_NAV = create(PATH_LCL, IMG_UP_NAV);

public static final ImageDescriptor DESC_REFRESH_DISABLED = create(PATH_DCL, "refresh.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_REFRESH = create(PATH_LCL, "refresh.svg"); //$NON-NLS-1$
public static final ImageDescriptor DESC_COLLAPSE_ALL = create(PATH_LCL, "collapseall.svg"); //$NON-NLS-1$
public static final ImageDescriptor DESC_EXT_POINT_OBJ = create(PATH_OBJ, "ext_point_obj.svg"); //$NON-NLS-1$
Expand Down
1 change: 0 additions & 1 deletion ...rg.eclipse.pde.runtime/src/org/eclipse/pde/internal/runtime/registry/RegistryBrowser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@ public void run() {
fRefreshAction.setText(PDERuntimeMessages.RegistryView_refresh_label);
fRefreshAction.setToolTipText(PDERuntimeMessages.RegistryView_refresh_tooltip);
fRefreshAction.setImageDescriptor(PDERuntimePluginImages.DESC_REFRESH);
fRefreshAction.setDisabledImageDescriptor(PDERuntimePluginImages.DESC_REFRESH_DISABLED);

fShowPluginsAction = new Action(PDERuntimeMessages.RegistryView_showRunning_label) {
@Override
Expand Down
2 changes: 0 additions & 2 deletions ui/org.eclipse.pde.ui.tests/tests/performance/plugin/org.eclipse.jdt.ui/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,6 @@
toolbarPath="org.eclipse.ui.edit.text.actionSet.presentation/Presentation"
id="org.eclipse.jdt.ui.edit.text.java.toggleMarkOccurrences"
definitionId="org.eclipse.jdt.ui.edit.text.java.toggleMarkOccurrences"
disabledIcon="$nl$/icons/full/dtool16/mark_occurrences.gif"
icon="$nl$/icons/full/etool16/mark_occurrences.gif"
helpContextId="toggle_mark_occurrences_action_context"
label="%toggleMarkOccurrences.label"
Expand Down Expand Up @@ -1515,7 +1514,6 @@
id="org.eclipse.jdt.ui.actions.NewTypeDropDown"
toolbarPath="Normal/JavaWizards"
class="org.eclipse.jdt.internal.ui.wizards.NewTypeDropDownAction"
disabledIcon="$nl$/icons/full/dtool16/newclass_wiz.gif"
icon="$nl$/icons/full/etool16/newclass_wiz.gif"
label="%OpenClassWizardAction.label"
style="pulldown"
Expand Down
1 change: 0 additions & 1 deletion ui/org.eclipse.pde.ui/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1823,7 +1823,6 @@
locationURI="popup:org.eclipse.ui.popup.any?after=additions">
<command
commandId="org.eclipse.pde.ui.importFromRepository"
disabledIcon="icons/dtool16/imp_extplug.png"
icon="icons/etool16/imp_extplug.png"
label="%importFromRepository.action.menu.name"
style="push"
Expand Down
25 changes: 0 additions & 25 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEPluginImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public class PDEPluginImages {
private static final String PATH_VIEW = ICONS_PATH + "view16/"; //$NON-NLS-1$
private static final String PATH_DVIEW = ICONS_PATH + "dview16/"; //$NON-NLS-1$
private static final String PATH_LCL = ICONS_PATH + "elcl16/"; //$NON-NLS-1$
private static final String PATH_LCL_DISABLED = ICONS_PATH + "dlcl16/"; //$NON-NLS-1$
private static final String PATH_TOOL = ICONS_PATH + "etool16/"; //$NON-NLS-1$
private static final String PATH_OVR = ICONS_PATH + "ovr16/"; //$NON-NLS-1$
private static final String PATH_WIZBAN = ICONS_PATH + "wizban/"; //$NON-NLS-1$
Expand Down Expand Up @@ -252,30 +251,6 @@ public class PDEPluginImages {
public static final ImageDescriptor DESC_FILTER = create(PATH_LCL, "filter_ps.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_FILTER_RELATED = create(PATH_LCL, "filter_related.png"); //$NON-NLS-1$

public static final ImageDescriptor DESC_ADD_ATT_DISABLED = create(PATH_LCL_DISABLED, "add_att.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_ALPHAB_SORT_CO_DISABLED = create(PATH_LCL_DISABLED, "alphab_sort_co.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_CLONE_ATT_DISABLED = create(PATH_LCL_DISABLED, "clone_att.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_CLONE_EL_DISABLED = create(PATH_LCL_DISABLED, "clone_el.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_GENERATE_CLASS_DISABLED = create(PATH_LCL_DISABLED, "generate_class.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_GOTOOBJ_DISABLED = create(PATH_LCL_DISABLED, "goto_obj.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_PROPERTIES_DISABLED = create(PATH_LCL_DISABLED, "properties.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_REFRESH_DISABLED = create(PATH_LCL_DISABLED, "refresh.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_REMOVE_ATT_DISABLED = create(PATH_LCL_DISABLED, "remove_att.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_HORIZONTAL_DISABLED = create(PATH_LCL_DISABLED, "th_horizontal.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_VERTICAL_DISABLED = create(PATH_LCL_DISABLED, "th_vertical.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_COLLAPSE_ALL_DISABLED = create(PATH_LCL_DISABLED, "collapseall.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_TOGGLE_EXPAND_STATE_DISABLED = create(PATH_LCL_DISABLED, "toggle_expand_state.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_LINK_WITH_EDITOR_DISABLED = create(PATH_LCL_DISABLED, "synced.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_CALLEES_DISABLED = create(PATH_LCL_DISABLED, "ch_callees.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_CALLERS_DISABLED = create(PATH_LCL_DISABLED, "ch_callers.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_DEP_LOOP_DISABLED = create(PATH_LCL_DISABLED, "dep_loop.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_FLAT_LAYOUT_DISABLED = create(PATH_LCL_DISABLED, "flatLayout.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_HIERARCHICAL_LAYOUT_DISABLED = create(PATH_LCL_DISABLED, "hierarchicalLayout.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_HISTORY_LIST_DISABLED = create(PATH_LCL_DISABLED, "history_list.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_DCLEAR = create(PATH_LCL_DISABLED, "clear.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_FILTER_DISABLED = create(PATH_LCL_DISABLED, "filter_ps.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_FILTER_RELATED_DISABLED = create(PATH_LCL_DISABLED, "filter_related.png"); //$NON-NLS-1$

public static final ImageDescriptor DESC_RUN_EXC = create(PATH_OBJ, "run_exc.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_DEBUG_EXC = create(PATH_OBJ, "debug_exc.png"); //$NON-NLS-1$
public static final ImageDescriptor DESC_PROFILE_EXC = create(PATH_OBJ, "profile_exc.png"); //$NON-NLS-1$
Expand Down
2 changes: 0 additions & 2 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/OrientableBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public void run() {
haction.setChecked(true);
haction.setToolTipText(PDEUIMessages.DetailsBlock_horizontal);
haction.setImageDescriptor(PDEPluginImages.DESC_HORIZONTAL);
haction.setDisabledImageDescriptor(PDEPluginImages.DESC_HORIZONTAL_DISABLED);

Action vaction = new Action("ver", IAction.AS_RADIO_BUTTON) { //$NON-NLS-1$
@Override
Expand All @@ -53,7 +52,6 @@ public void run() {
vaction.setChecked(false);
vaction.setToolTipText(PDEUIMessages.DetailsBlock_vertical);
vaction.setImageDescriptor(PDEPluginImages.DESC_VERTICAL);
vaction.setDisabledImageDescriptor(PDEPluginImages.DESC_VERTICAL_DISABLED);
form.getToolBarManager().add(haction);
form.getToolBarManager().add(vaction);
}
Expand Down
1 change: 0 additions & 1 deletion ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDEMultiPageContentOutline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ public SortingAction() {
PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IHelpContextIds.OUTLINE_SORT_ACTION);
setText(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_label);
setImageDescriptor(PDEPluginImages.DESC_ALPHAB_SORT_CO);
setDisabledImageDescriptor(PDEPluginImages.DESC_ALPHAB_SORT_CO_DISABLED);
setToolTipText(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_tooltip);
setDescription(PDEUIMessages.PDEMultiPageContentOutline_SortingAction_description);
setChecked(sortingOn);
Expand Down
1 change: 0 additions & 1 deletion ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/ToggleLinkWithEditorAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public ToggleLinkWithEditorAction(PDEFormEditor editor) {
setToolTipText(PDEUIMessages.ToggleLinkWithEditorAction_toolTip);
setDescription(PDEUIMessages.ToggleLinkWithEditorAction_description);
setImageDescriptor(PDEPluginImages.DESC_LINK_WITH_EDITOR);
setDisabledImageDescriptor(PDEPluginImages.DESC_LINK_WITH_EDITOR_DISABLED);
}

@Override
Expand Down
1 change: 0 additions & 1 deletion ....pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/FilterRelatedExtensionsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public class FilterRelatedExtensionsAction extends Action {

public FilterRelatedExtensionsAction(TreeViewer treeViewer, FormFilteredTree filteredTree, ExtensionsSection section) {
setImageDescriptor(PDEPluginImages.DESC_FILTER_RELATED);
setDisabledImageDescriptor(PDEPluginImages.DESC_FILTER_RELATED_DISABLED);
// Extensions section attaches this action to the global find keybinding
// String filterBinding = ((IBindingService) PlatformUI.getWorkbench().getAdapter(IBindingService.class)).getBestActiveBindingFormattedFor(ActionFactory.FIND.getCommandId());
setText(PDEUIMessages.Actions_filter_relatedPluginElements /*+ ((filterBinding != null) ? "\t" + filterBinding : "")*/);
Expand Down
1 change: 0 additions & 1 deletion ...clipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/actions/ToggleExpandStateAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public class ToggleExpandStateAction extends Action {

public ToggleExpandStateAction(FormFilteredTree filteredTree, TreeViewer treeViewer) {
setImageDescriptor(PDEPluginImages.DESC_TOGGLE_EXPAND_STATE);
setDisabledImageDescriptor(PDEPluginImages.DESC_TOGGLE_EXPAND_STATE_DISABLED);
setText(PDEUIMessages.ExtensionsPage_toggleExpandState);
fExtensionTree = treeViewer;
fFilteredTree = filteredTree;
Expand Down
10 changes: 0 additions & 10 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,11 +462,6 @@ public ImageDescriptor getImageDescriptor() {
return PDEPluginImages.DESC_DELETE;
}

@Override
public ImageDescriptor getDisabledImageDescriptor() {
return PDEPluginImages.DESC_REMOVE_ATT_DISABLED;
}

@Override
public void run() {
handleDelete();
Expand Down Expand Up @@ -556,11 +551,6 @@ public void run() {
public ImageDescriptor getImageDescriptor() {
return PDEPluginImages.DESC_DELETE;
}

@Override
public ImageDescriptor getDisabledImageDescriptor() {
return PDEPluginImages.DESC_REMOVE_ATT_DISABLED;
}
};
deleteAction.setEnabled(page.getModel().isEditable());
manager.add(deleteAction);
Expand Down
Loading
Loading