Merged
Conversation
laeubi
reviewed
May 6, 2025
| @Component | ||
| @AdapterTypes(adaptableClass = IProject.class, adapterNames = Project.class) | ||
| public class BndPluginAdapter implements IAdapterFactory { | ||
| public class PdeBndAdapter implements IAdapterFactory { |
Contributor
There was a problem hiding this comment.
As this is an example for such an adapter, should be really mention PDE here?
Suggested change
| public class PdeBndAdapter implements IAdapterFactory { | |
| public class MyBndProjectAdapter implements IAdapterFactory { |
Contributor
Author
There was a problem hiding this comment.
Ah ok, I thought it was supposed to be the current PdeBndAdapter.java but just with an initial name. I was searching for the class in the readme (BndPluginAdapter) and did not find something. So I wanted to use a name from something which really exists, so I can have a look
laeubi
reviewed
May 6, 2025
- e.g. mention some important classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.